tracd 1.5.2 --daemonize fails, "TypeError: an integer is required (got type str)"

[stu-trac-@…]

[17483/trunk/trac/util/daemon.py] changed daemonize from open to os.open, but didn't convert from Python 'rb' and 'ab+' to os.open flags, result of trying to run tracd -d is:

Traceback (most recent call last):
  File "/usr/local/bin/tracd", line 11, in <module>
    load_entry_point('Trac==1.5.2', 'console_scripts', 'tracd')()
  File "/usr/local/lib/python3.8/site-packages/trac/web/standalone.py", line 366, in main
    daemon.daemonize(pidfile=args.pidfile, progname='tracd',
  File "/usr/local/lib/python3.8/site-packages/trac/util/daemon.py", line 71, in daemonize
    stdin = os.open(stdin, 'rb')
TypeError: an integer is required (got type str)

[Ryan J Ollos]

os.open requires ​integer flags. This change seems to work. What do you think, Jun?

trac/util/daemon.py

@@ -68 +68 @@
     # The process is now daemonized, redirect standard file descriptors
     for stream in sys.stdout, sys.stderr:
         stream.flush()
-    stdin = os.open(stdin, 'rb')
-    stdout = os.open(stdout, 'ab+')
-    stderr = os.open(stderr, 'ab+', 0)
+    stdin = open(stdin, 'rb')
+    stdout = open(stdout, 'ab+')
+    stderr = open(stderr, 'ab+', 0)
     os.dup2(stdin.fileno(), sys.stdin.fileno())
     os.dup2(stdout.fileno(), sys.stdout.fileno())
     os.dup2(stderr.fileno(), sys.stderr.fileno())

I tried switching to integer flags for os.open, but then:

Traceback (most recent call last):
  File "/Users/rjollos/.pyenv/versions/trac-py386/bin/tracd", line 33, in <module>
    sys.exit(load_entry_point('Trac', 'console_scripts', 'tracd')())
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/web/standalone.py", line 366, in main
    daemon.daemonize(pidfile=args.pidfile, progname='tracd',
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/util/daemon.py", line 80, in daemonize
    os.dup2(stdin.fileno(), sys.stdin.fileno())
AttributeError: 'int' object has no attribute 'fileno'

[Jun Omae]

Ah, the changes in [d373b6ded/jomae.git] (log:jomae.git@1.5-py3) was incomplete.

The intention of the using os.open() is that avoiding text/binary mode for built-in open() because it just wants to get file descriptors for os.dup2() with std{in,out,err}.

Of course, your suggested changes are correct.

trac/util/daemon.py

@@ -68 +68 @@
     # The process is now daemonized, redirect standard file descriptors
     for stream in sys.stdout, sys.stderr:
         stream.flush()
-    stdin = os.open(stdin, 'rb')
-    stdout = os.open(stdout, 'ab+')
-    stderr = os.open(stderr, 'ab+', 0)
-    os.dup2(stdin.fileno(), sys.stdin.fileno())
-    os.dup2(stdout.fileno(), sys.stdout.fileno())
-    os.dup2(stderr.fileno(), sys.stderr.fileno())
+    stdin = os.open(stdin, os.O_RDONLY)
+    stdout = os.open(stdout,  os.O_RDWR | os.O_APPEND)
+    stderr = os.open(stderr, os.O_RDWR | os.O_APPEND)
+    os.dup2(stdin, sys.stdin.fileno())
+    os.dup2(stdout, sys.stdout.fileno())
+    os.dup2(stderr, sys.stderr.fileno())
+    for fd in (stdin, stdout, stderr):
+        os.close(fd)
 
     if pidfile:
         # Register signal handlers to ensure atexit hooks are called on exit

[Ryan J Ollos]

Thanks, Jun. Fixed in r17497.