KeyError for Query.get_modes().get(...)

[Ryan J Ollos]

Found in log files:

2019-08-13 03:56:35,690 Trac[main] ERROR: [23.94.17.122] Internal Server Error: <RequestWithSession "POST '/query'">, referrer 'https://bugs.jqueryui.com/'
Traceback (most recent call last):
  File "/var/www/bugs.jqueryui.com/private/pve/local/lib/python2.7/site-packages/trac/web/main.py", line 648, in _dispatch_request
    dispatcher.dispatch(req)
  File "/var/www/bugs.jqueryui.com/private/pve/local/lib/python2.7/site-packages/trac/web/main.py", line 249, in dispatch
    resp = chosen_handler.process_request(req)
  File "/var/www/bugs.jqueryui.com/private/pve/local/lib/python2.7/site-packages/trac/ticket/query.py", line 941, in process_request
    constraints = self._get_constraints(req)
  File "/var/www/bugs.jqueryui.com/private/pve/local/lib/python2.7/site-packages/trac/ticket/query.py", line 1099, in _get_constraints
    modes = Query.get_modes().get(fields[field]['type'])
KeyError: u"paU7mLAp'))"

[Ryan J Ollos]

Proposed change:

trac/ticket/query.py

@@ -1094 +1094 @@
             if add_num is not None:
                 field = req.args.get('add_filter_' + add_num,
                                      req.args.get('add_clause_' + add_num))
-                if field:
+                if field and field in fields:
                     clause = constraints.setdefault(int(add_num), {})
                     modes = Query.get_modes().get(fields[field]['type'])
                     mode = modes[0]['value'] if modes else ''