Edgewall Software

Opened 7 years ago

Closed 7 years ago

#12764 closed defect (fixed)

Subscribers without RecipientMatcher and from header in mail ignore use_short_addr and smtp_default_domain options — at Version 3

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.2.2
Component: notification Version: 1.2
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Fix [notification] use_short_addr and smtp_default_domain options being ignored for subscriptions without email address.

API Changes:
Internal Changes:

Description

Currently, RecipientMatcher class handles use_short_addr and smtp_default_domain options in [notification]. It means subscriptions from subscribers without RecipientMatcher ignore their options.

For example, NewTicketSubscriber in CookBook/Notification/Subscriptions@11.

I consider the handling should move to EmailDistributor.distribute().

Change History (3)

comment:1 by Jun Omae, 7 years ago

Proposed changes in jomae.git@t12764 but it is unable to remove RecipientMatcher.match_recipients from existent ticket subscribers because it needs to solve authenticated from values in ticket properties (reporter, owner, cc).

comment:2 by Jun Omae, 7 years ago

I rebased and refactored the branch. I'm going to push to 1.2-stable if no objections.

comment:3 by Jun Omae, 7 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed in [15849] and merged in [15850].

Note: See TracTickets for help on using tickets.