Edgewall Software

Changes between Initial Version and Version 1 of Ticket #12576, comment 9


Ignore:
Timestamp:
Sep 2, 2016, 9:49:07 PM (8 years ago)
Author:
Ryan J Ollos

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12576, comment 9

    initial v1  
    1010To reinforce what Jun said, I believe `commit_updater` does exactly what you want, and I think you have an InstallationIssue.
    1111
    12 While `CommitTicketUpdater` does not update the ticket comment by modifying the `ticket_change` table when a changeset is modified (as you pointed out in comment:4 with the code snippet), the new changeset message is stored in the database (as Jun mentioned) and the new changeset message will be rendered in the comment by `CommitTicketReferenceMacro` under normal circumstances. This is because `CommitTicketReferenceMacro` first tries to get the changeset message from the database, and only uses the content in the `WikiProcessor` if an exception occurs while getting the changeset attributes from the repository: [browser:tags/trac-1.0.12/tracopt/ticket/commit_updater.py@:306,310#L299].
     12While `CommitTicketUpdater` does not update the ticket comment by modifying the `ticket_change` table when a changeset is modified (as you pointed out in comment:4 with the code snippet), the new changeset message is stored in the `revision` table (as Jun mentioned) and the new changeset message will be rendered in the comment by `CommitTicketReferenceMacro` under normal circumstances. This is because `CommitTicketReferenceMacro` first tries to get the changeset message from the database, and only uses the content in the `WikiProcessor` if an exception occurs while getting the changeset attributes from the repository: [browser:tags/trac-1.0.12/tracopt/ticket/commit_updater.py@:306,310#L299].
    1313
    1414As a concrete example, consider th:comment:2:ticket:4618.