Edgewall Software

Opened 8 years ago

Last modified 7 years ago

#12566 closed enhancement

Loader should log ImportError without traceback — at Version 2

Reported by: Ryan J Ollos Owned by: Jun Omae
Priority: normal Milestone: 1.0.14
Component: general Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

ImportError while loading plugins is logged at ERROR level without traceback.

API Changes:
Internal Changes:

Description

Discussed in comment:7:ticket:12282 and the comments that follow, setuptools is improperly raising an ImportError since 20.8.1 when an extras package is not found. Tracebacks are appearing in the log. Instead, we'll log the exception with a message at ERROR level.

Change History (2)

comment:1 by Ryan J Ollos, 8 years ago

Milestone: 1.0.131.0.14

Ticket moved forward so that 1.0.13 can be released.

comment:2 by Jun Omae, 7 years ago

Release Notes: modified (diff)

Fixed in [15237] and merged in [15238-15239].

Also, confirmed with built wheel package:

$ /dev/shm/t12566/bin/pip list --local
Genshi (0.6)
pip (1.5.4)
setuptools (28.8.0)
Trac (1.0.14.dev0)
wheel (0.29.0)
$ /dev/shm/t12566/bin/trac-admin /var/trac/1.0-sqlite
Welcome to trac-admin 1.0.14.dev0
Interactive Trac administration console.
Copyright (C) 2003-2013 Edgewall Software

Type:  '?' or 'help' for help on commands.

Trac [/var/trac/1.0-sqlite]> x
03:56:23 Trac[env] INFO: -------------------------------- environment startup [Trac 1.0.14.dev0] --------------------------------
03:56:23 Trac[loader] ERROR: Skipping "trac.mimeview.pygments = trac.mimeview.pygments [pygments]": (ImportError: No module named pygments)
03:56:23 Trac[loader] ERROR: Skipping "trac.mimeview.txtl = trac.mimeview.txtl [textile]": (ImportError: No module named textile)
Error: Command not found

No documentation found for 'x'. Use 'help' to see the list of commands.
Note: See TracTickets for help on using tickets.