Edgewall Software

Opened 8 years ago

Closed 7 years ago

Last modified 4 years ago

#12564 closed enhancement (fixed)

Add a test for Request.__repr__ — at Version 6

Reported by: Tim Graham <timograham@…> Owned by: Tim Graham <timograham@…>
Priority: normal Milestone: 1.3.2
Component: web frontend Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Added test coverage for Request.__repr__.

Description

Currently you can comment out some querystring lines in Request.__repr__ and the tests will still pass.

Change History (7)

by Tim Graham <timograham@…>, 8 years ago

Attachment: 12564.diff​ added

comment:1 by Jun Omae, 8 years ago

Milestone: → next-stable-1.0.x
Type: defect → enhancement

Thanks. However we should add more test cases if we'd like to test it.

comment:2 by Ryan J Ollos, 7 years ago

Milestone: next-stable-1.0.x → next-stable-1.2.x

Moved ticket assigned to next-stable-1.0.x since maintenance of 1.0.x is coming to a close. Please move the ticket back if it's critical to fix on 1.0.x.

comment:3 by Ryan J Ollos, 7 years ago

Milestone: next-stable-1.2.x → 1.3.2
Owner: set to Ryan J Ollos
Release Notes: modified (diff)
Status: new → assigned

comment:4 by Ryan J Ollos, 7 years ago

Resolution: → fixed
Status: assigned → closed

Two test cases committed to trunk in r15592. I didn't see any other paths that needed coverage, but feel free to extend the test coverage.

comment:5 by Ryan J Ollos, 7 years ago

Owner: changed from Ryan J Ollos to Tim Graham <timograham@…>

comment:6 by Ryan J Ollos, 4 years ago

Internal Changes: modified (diff)
Release Notes: modified (diff)
Note: See TracTickets for help on using tickets.