Edgewall Software

Changes between Version 3 and Version 4 of Ticket #12426, comment 2


Ignore:
Timestamp:
Apr 8, 2016, 3:17:40 AM (8 years ago)
Author:
Ryan J Ollos

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #12426, comment 2

    v3 v4  
    33I tended towards using `getint` and `getbool`, thus always raising `HTTPBadRequest` on bad input. However, we may want to handle differently the two common scenarios: values input by the user and values not directly input by the user.
    44
    5 An example of values input by the user would be //going back x days// on the Timeline page. For the case that the value input is not an integer I initially chose an `HTTPBadRequest`, but reconsidered: [b5f40dee/rjollos.git].
     5An example of values input by the user would be //going back x days// on the Timeline page. For the case that the input value is not an integer I initially chose an `HTTPBadRequest`, but reconsidered: [b5f40dee/rjollos.git].
    66
    77In cases for which the user does not directly enter a value, such as the page number on search or query results, I'm more convinced we should raise an `HTTPBadRequest` on bad input: [13a4e04a/rjollos.git#file0]. In these cases the bad input would only occur due to bots or the user editing the URL.