Edgewall Software

Changes between Version 2 and Version 3 of Ticket #12426, comment 2


Ignore:
Timestamp:
Apr 8, 2016, 3:16:42 AM (8 years ago)
Author:
Ryan J Ollos

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #12426, comment 2

    v2 v3  
    11Proposed changes in log:rjollos.git:t12426_request_methods. I'm just posting for initial feedback on the methods added to the `_RequestArgs` class. There is still work to be done in utilizing the new methods throughout the codebase.
    22
    3 I tended towards using `getint` and `getbool`, thus always raising `HTTPBadRequest` on bad input. However, we may want to hander differently the two common scenarios: values input by the user and values not directly input by the user.
     3I tended towards using `getint` and `getbool`, thus always raising `HTTPBadRequest` on bad input. However, we may want to handle differently the two common scenarios: values input by the user and values not directly input by the user.
    44
    55An example of values input by the user would be //going back x days// on the Timeline page. For the case that the value input is not an integer I initially chose an `HTTPBadRequest`, but reconsidered: [b5f40dee/rjollos.git].