Edgewall Software

Changes between Initial Version and Version 1 of Ticket #12414, comment 11


Ignore:
Timestamp:
May 7, 2020, 8:21:48 PM (4 years ago)
Author:
Ryan J Ollos

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12414, comment 11

    initial v1  
    33
    44You can append to the comment in `ITicketManipulator.validate_ticket`, and update the PR in `ITicketChangeListener.{ticket_created/ticket_changed/ticket_comment_modified}`, or update the PR in `ITicketManipulator.apply_ticket_side_effects` if you need access to the `req` to get the PR id?
     5
     6`ITicketManipulator.validate_ticket` is primarily document as being for identifying problems and rejecting changes, but it's location in the request processing makes it very useful for modifying the ticket changes.
     7
     8I think it's been discussed before, `ITicketChangeListener` might be more useful if the request was passed as an argument. One way would be to move the call to `ITicketChangeListener` out of the model object. Also, it might be more user friendly if ticket changes were passed in a dict that included the `cnum` and `cdate`, rather than passing the `ticket` and `old_values`.