Custom field "milestone" is not appeared with the field is defined and defined milestones are removed

[Jun Omae]

Custom field is allow to use the same name of ticket field when no defined enums/components/milestones/versions. Actually, priority, version, component, resolution, severity and type fields is appeared in ticket box and form.

However, milestone field is not appeared in ticket form. The milestone is appeared in ticket view.

[ticket-custom]
priority = text
priority.format = plain
priority.label = (priority)
priority.options =
priority.order = 1
priority.value =
milestone = text
milestone.format = plain
milestone.label = (milestone)
milestone.options =
milestone.order = 2
milestone.value =
version = text
version.format = plain
version.label = (version)
version.options =
version.order = 3
version.value =
component = text
component.format = plain
component.label = (component)
component.options =
component.order = 4
component.value =
resolution = text
resolution.format = plain
resolution.label = (resolution)
resolution.options =
resolution.order = 5
resolution.value =
severity = text
severity.format = plain
severity.label = (severity)
severity.options =
severity.order = 6
severity.value =
type = text
type.format = plain
type.label = (type)
type.options =
type.order = 7
type.value =

[Jun Omae]

Query system crashes in this case.

2016-03-14 14:37:17,211 Trac[main] ERROR: Internal Server Error: <RequestWithSession "GET '/query'">, referrer None
Traceback (most recent call last):
  File "/home/jun66j5/src/tracdev/git/trac/web/main.py", line 554, in _dispatch_request
    dispatcher.dispatch(req)
  File "/home/jun66j5/src/tracdev/git/trac/web/main.py", line 247, in dispatch
    resp = chosen_handler.process_request(req)
  File "/home/jun66j5/src/tracdev/git/trac/ticket/query.py", line 1004, in process_request
    return self.display_html(req, query)
  File "/home/jun66j5/src/tracdev/git/trac/ticket/query.py", line 1121, in display_html
    data = query.template_data(context, tickets, orig_list, orig_time, req)
  File "/home/jun66j5/src/tracdev/git/trac/ticket/query.py", line 768, in template_data
    for opt in field['options']]
KeyError: 'options'

[Jun Omae]

The following would fix missing milestone as custom field in ticket form. That issue in comment:3 would be fixed in #12399.

trac/ticket/tests/web_ui.py

@@ -16 +16 @@
 from trac.core import TracError
 from trac.resource import ResourceNotFound
 from trac.test import EnvironmentStub, Mock, MockPerm, locale_en
+from trac.ticket.api import TicketSystem
 from trac.ticket.model import Ticket
 from trac.ticket.web_ui import TicketModule
 from trac.util.datefmt import utc
@@ -110 +111 @@
         self.assertRaises(ResourceNotFound,
                           self.ticket_module.process_request, req)
 
+    def test_newticket_with_milestone_as_custom_field(self):
+        self.env.config.set('ticket-custom', 'milestone', 'text')
+        self.env.db_transaction("DELETE FROM milestone")
+        tktsys = TicketSystem(self.env)
+        tktsys.reset_ticket_fields()
+        del tktsys.custom_fields
+
+        req = self._create_request(path_info='/newticket')
+        self.assertEqual(True, self.ticket_module.match_request(req))
+        resp = self.ticket_module.process_request(req)
+        for field in resp[1]['fields']:
+            if field['name'] == 'milestone':
+                self.assertTrue(field['custom'])
+                self.assertFalse(field['options'])
+                self.assertFalse(field.get('optgroups'))
+                break
+        else:
+            self.fail('Missing milestone in fields')
+
 
 def suite():
     suite = unittest.TestSuite()

trac/ticket/web_ui.py

@@ -1496 +1496 @@
                     if 'TICKET_MODIFY' in req.perm(ticket.resource):
                         field['skip'] = False
                         owner_field = field
-            elif name == 'milestone':
+            elif name == 'milestone' and not field.get('custom'):
                 milestones = [Milestone(self.env, opt)
                               for opt in field['options']]
                 milestones = [m for m in milestones

[Jun Omae]

Proposed changes in log:jomae.git@t12400, added unit tests for other fields.

[Jun Omae]

Comiitted in [14633] and merged to trunk in [14634].