Edgewall Software

Opened 8 years ago

Closed 8 years ago

#12381 closed defect (fixed)

Auto-preview in ticket view restores "Oldest first" of changelog — at Version 6

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.0.11
Component: ticket system Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Fix resetting Oldest first after auto-preview of ticket form.

API Changes:
Internal Changes:

Description (last modified by Jun Omae)

How to reproduce:

  1. Visit a ticket and select Newest first or Threaded in prefs of changelog.
  2. Type in textarea for ticket comment.
  3. Wait for the auto-preview
  4. Oldest first is selected and order of ticket comments is changed.
  5. XMLHttpRequest with ticket_comments_order:"oldest" is sent twice.

I think we should keep the order of ticket comments even if auto-preview is fired.

Change History (6)

comment:1 by Jun Omae, 8 years ago

Description: modified (diff)

comment:2 by Jun Omae, 8 years ago

Milestone: next-stable-1.0.x → 1.0.11
Owner: set to Jun Omae
Status: new → assigned

Proposed changes in log:jomae.git@t12381, which added applyCommentsOrder() in threaded_comments.js.

comment:3 by Ryan J Ollos, 8 years ago

Changes look good. Test with Chrome 48 and Opera 35 on OSX 10.11.3.

comment:4 by Jun Omae, 8 years ago

Release Notes: modified (diff)

Thanks for the review! Committed in [14598]. However, merging the changes to trunk is conflicted. I'll rework for trunk.

comment:5 by Jun Omae, 8 years ago

Proposed changes for trunk in jomae.git@t12381.trunk ([255a864c1/jomae.git]).

comment:6 by Jun Omae, 8 years ago

Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Refactored threaded_comments.js for 1.0-stable in [14681] and committed in [14682].

Note: See TracTickets for help on using tickets.