Opened 8 years ago
Last modified 8 years ago
#12325 closed defect
ValueError: invalid literal for int() with base 10: ')(,.",\'",[--' — at Initial Version
Reported by: | Ryan J Ollos | Owned by: | Ryan J Ollos |
---|---|---|---|
Priority: | normal | Milestone: | 1.0.11 |
Component: | general | Version: | |
Severity: | normal | Keywords: | |
Cc: | Branch: | ||
Release Notes: |
Don't raise |
||
API Changes: | |||
Internal Changes: |
Description
2016-01-17 16:55:07,918 Trac[main] ERROR: Internal Server Error: <RequestWithSession "GET '/report?asc=%29%28%2C.%22%2C%27%22%2C%5B--&format=csv'">, referrer None Traceback (most recent call last): File "/srv/trac-hacks.org/pve/lib/python2.7/site-packages/trac/web/main.py", line 554, in _dispatch_request dispatcher.dispatch(req) File "/srv/trac-hacks.org/pve/lib/python2.7/site-packages/trac/web/main.py", line 247, in dispatch resp = chosen_handler.process_request(req) File "/srv/trac-hacks.org/pve/lib/python2.7/site-packages/trac/ticket/report.py", line 176, in process_request template, data, content_type = self._render_list(req) File "/srv/trac-hacks.org/pve/lib/python2.7/site-packages/trac/ticket/report.py", line 296, in _render_list asc = bool(int(req.args.get('asc', 1))) ValueError: invalid literal for int() with base 10: ')(,.",\'",[--'
Proposed fix:
-
trac/ticket/report.py
diff --git a/trac/ticket/report.py b/trac/ticket/report.py index ec94423..958baa1 100644
a b from trac.db import get_column_names 30 30 from trac.perm import IPermissionRequestor 31 31 from trac.resource import Resource, ResourceNotFound 32 32 from trac.ticket.api import TicketSystem 33 from trac.util import as_ int, content_disposition33 from trac.util import as_bool, as_int, content_disposition 34 34 from trac.util.datefmt import format_datetime, format_time, from_utimestamp 35 35 from trac.util.presentation import Paginator 36 36 from trac.util.text import exception_to_unicode, to_unicode, quote_query_string … … class ReportModule(Component): 293 293 def _render_list(self, req): 294 294 """Render the list of available reports.""" 295 295 sort = req.args.get('sort', 'report') 296 asc = bool(int(req.args.get('asc', 1)))296 asc = as_bool(req.args.get('asc', 1)) 297 297 format = req.args.get('format') 298 298 299 299 rows = self.env.db_query("""
Note:
See TracTickets
for help on using tickets.