#12260 closed defect (fixed)
The Show Property Changes checkbox has no effect on t.e.o — at Version 5
| Reported by: | Ryan J Ollos | Owned by: | Ryan J Ollos |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.2 |
| Component: | general | Version: | |
| Severity: | normal | Keywords: | |
| Cc: | Branch: | ||
| Release Notes: |
Fixed regression in Show property changes preference on ticket page, after upgrade to jQuery 1.11.3 (#11019). |
||
| API Changes: | |||
| Internal Changes: | |||
Description
The checkbox does not seem to be working on t.e.o (Trac 1.2dev), but it functions correctly on the other Edgewall Trac sites, which run Trac 1.0.9.
I haven't tested whether the problem is reproducible with a clean install of 1.2dev.
Change History (5)
comment:1 by , 8 years ago
comment:2 by , 8 years ago
Works for me in Firefox, but not in Chrome.
showPropertyChanges.attr('checked') seems to always be "checked" in Chrome. Maybe showPropertyChanges.prop('checked') should be used instead?
(Strange that it works with Trac 1.0.9 though.)
comment:3 by , 8 years ago
| Milestone: | → 1.2 |
|---|---|
| Owner: | set to |
| Status: | new → assigned |
I see the issue with Chrome 47 and Firefox 42 on Mac OSX. I can reproduce on the trunk, but not on 1.0-stable. The difference in behavior is probably due to the upgrade of the jQuery libraries in #11019.
The proposed fix works well and makes sense to me. I'll push the change in a day or so if there is no other feedback. Thanks!
comment:4 by , 8 years ago
(Ah, probably it only "worked" for me because I still had the old jQuery cached in Firefox.)
.attr() versus .prop() is also mentioned in the jQuery upgrade guide linked in #11019.
comment:5 by , 8 years ago
| Release Notes: | modified (diff) |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
Fixed in [14372].
Also, I don't see any errors in the browser console.