Opened 9 years ago
Last modified 9 years ago
#12017 closed defect
UnicodeDecodeError in log file — at Version 1
Reported by: | Ryan J Ollos | Owned by: | Dirk Stöcker |
---|---|---|---|
Priority: | normal | Milestone: | 1.0.7 |
Component: | general | Version: | |
Severity: | normal | Keywords: | |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description (last modified by )
Running the latest SpamFilter plugin [13942], I find the following errors in the log:
2015-04-01 23:15:33,851 Trac[main] ERROR: Internal Server Error: Traceback (most recent call last): File "/srv/trac-hacks.org/pve/lib/python2.6/site-packages/Trac-1.0.5-py2.6.egg/trac/web/main.py", line 513, in _dispatch_request dispatcher.dispatch(req) File "/srv/trac-hacks.org/pve/lib/python2.6/site-packages/Trac-1.0.5-py2.6.egg/trac/web/main.py", line 187, in dispatch self._pre_process_request(req, chosen_handler) File "/srv/trac-hacks.org/pve/lib/python2.6/site-packages/Trac-1.0.5-py2.6.egg/trac/web/main.py", line 334, in _pre_process_request chosen_handler = filter_.pre_process_request(req, chosen_handler) File "/srv/trac-hacks.org/pve/lib/python2.6/site-packages/TracSpamFilter-1.0.6dev_r13942-py2.6.egg/tracspamfilter/captcha/api.py", line 167, in pre_process_request elif req.args.get('captcha_response', "") == exp: File "/srv/trac-hacks.org/pve/lib/python2.6/site-packages/Trac-1.0.5-py2.6.egg/trac/web/api.py", line 355, in __getattr__ value = self.callbacks[name](self) File "/srv/trac-hacks.org/pve/lib/python2.6/site-packages/Trac-1.0.5-py2.6.egg/trac/web/api.py", line 338, in <lambda> 'args': lambda req: arg_list_to_args(req.arg_list), File "/srv/trac-hacks.org/pve/lib/python2.6/site-packages/Trac-1.0.5-py2.6.egg/trac/web/api.py", line 355, in __getattr__ value = self.callbacks[name](self) File "/srv/trac-hacks.org/pve/lib/python2.6/site-packages/Trac-1.0.5-py2.6.egg/trac/web/api.py", line 704, in _parse_arg_list value = unicode(value.value, 'utf-8') UnicodeDecodeError: 'utf8' codec can't decode byte 0xff in position 37: invalid start byte
SpamFilter plugin should at least trap the UnicodeDecodeError
s so that tracebacks don't result in the log.
Change History (1)
comment:1 by , 9 years ago
Component: | plugin/spamfilter → general |
---|---|
Description: | modified (diff) |
Note:
See TracTickets
for help on using tickets.
No. That is not a SpamFilter issue. We can raise the same error on any components, e.g.
/wiki?name=%FF
,/query?name=%FF
.trac/web/api.py
After the patch, the following without traceback would be logged by invalid enoding.
I noticed that
/wiki?%FF=xxxx
doesn't lead the same error. I think we should decode the names to unicode with utf-8 encoding.