Symbolic link for trac.ini overwritten when saving Configuration object

[Ryan J Ollos]

I tried storing trac.ini in a version-controlled directory outside of the Environment, using a symbolic link in the Environment conf directory. The symbolic link is not followed when saving the Configuration object.

Investigation revealed the following:

user@ubuntu:~/Workspace$ touch file
user@ubuntu:~/Workspace$ ln -s file link
user@ubuntu:~/Workspace$ ls -al file link
-rw-rw-r-- 1 user user 0 Mar 25 21:17 file
lrwxrwxrwx 1 user user 4 Mar 25 21:17 link -> file

Python 2.7.6 (default, Mar 22 2014, 22:59:56) 
[GCC 4.8.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import os
>>> os.path.realpath('/home/user/Workspace/link')
'/home/user/Workspace/file'

The following patch appears to work.

trac/config.py

@@ -129 +129 @@
     when the file has changed.
     """
     def __init__(self, filename, params={}):
-        self.filename = filename
+        self.filename = os.path.realpath(filename)  # follow any symlinks
         self.parser = UnicodeParser()
         self._parsed_sections = {}
         self.parents = []

Inherited files and files defined in PathOptions are resolved relative to the location of trac.ini. Before the patch this is always the Environment conf directory. I think the behaviour is better after the patch.