Edgewall Software

Changes between Initial Version and Version 1 of Ticket #11868, comment 1


Ignore:
Timestamp:
Dec 8, 2014, 1:27:19 AM (9 years ago)
Author:
Ryan J Ollos

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #11868, comment 1

    initial v1  
    1 The `get_known_users` method added to `EnvironmentStub` in [2799] looks like an unnecessary override that makes it difficult to test the true behaviour of `get_known_users`. Removing the override is an API change; if anyone has concerns about that I can probably find a way to keep some backwards compatibility. A search of t-h.o reveals only one use of `EnvironmentStub.known_users`: [th:browser:/tracformsplugin/trunk/0.11/tracforms/formdb.py@11137:418#L414].
     1The `get_known_users` method added to `EnvironmentStub` in [2799] looks like an unnecessary override that makes it difficult to test the true behaviour of `get_known_users`. It's straightforward to modify the tests to make the override unnecessary.
     2
     3Removing the override is an API change; if anyone has concerns about that I can probably find a way to keep some backwards compatibility. A search of t-h.o reveals only one use of `EnvironmentStub.known_users`: [th:browser:/tracformsplugin/trunk/0.11/tracforms/formdb.py@11137:418#L414].