Edgewall Software

Opened 10 years ago

Last modified 9 years ago

#11813 closed enhancement

Move default handler preference to another preference tab — at Version 8

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.1.3
Component: general Version:
Severity: normal Keywords: preferences
Cc: Branch:
Release Notes:

Improved layout of elements on the Advanced, Date & Time and Language preferences panels.

API Changes:
Internal Changes:

Description

It was discussed in comment:28:ticket:11519 that the General tab might not be the best location for the Default Handler preference. We'll consider moving it to a different, or new, tab.

Change History (8)

comment:1 by Ryan J Ollos, 10 years ago

Some proposed changes in log:rjollos.git:t11813. Any thoughts on the new Navigation preferences tab?

[e2fa04e6/rjollos.git] is unrelated and could be backported to 1.0-stable.

comment:2 by Ryan J Ollos, 10 years ago

Release Notes: modified (diff)

[e2fa04e6/rjollos.git] applied to 1.0-stable in [13262], merged to trunk in [13263]. I'll wait a bit longer to see if there is feedback on primary changes for this ticket: [c18de801/rjollos.git].

comment:3 by Peter Suter, 10 years ago

Replying to rjollos:

Can we foresee any additional entries for Keyboard shortcuts?

One could look to plugins for inspiration, e.g.:

Neither has preferences at the moment, but including them in core might well lead to additional checkboxes. Navigation would not fit well for those though.

User interface and Navigation both seems acceptable to me for the default handler.

Navigation seems good for anything related to the nav bars. It seems acceptable for most of the existing TracAccessibility keyboard shortcuts (except e for editing.)

Accessibility might also fit those, but maybe not much else.

At the moment I have maybe a slight preference for keeping Keyboard shortcuts and moving default handler to User interface, but if Navigation is chosen instead that's fine as well.

comment:4 by Ryan J Ollos, 10 years ago

Another possibility for combining preferences panels is to locate Date & Time and Language together on a panel title Localization.

comment:5 by Ryan J Ollos, 10 years ago

The change in indentation of two paragraph texts in [13262] results in noise in the message extraction. I tried the suggestions in comment:13:ticket:11127. HTML comment markers are only effective if wrapped in an i18n:msg:

  • trac/prefs/templates/prefs_advanced.html 

    diff --git a/trac/prefs/templates/prefs_advanced.html b/trac/prefs/templates/pre
index 82fb2af..583d4b8 100644
    a b  
    1313    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
    1414<html xmlns="http://www.w3.org/1999/xhtml"
    1515      xmlns:py="http://genshi.edgewall.org/"
     16      xmlns:i18n="http://genshi.edgewall.org/i18n"
    1617      xmlns:xi="http://www.w3.org/2001/XInclude">
    1718  <xi:include href="prefs.html" />
    1819  <head>
    … …  
    3233        <tr>
    3334          <th></th>
    3435          <td>
    35             <p class="hint">The session key is used to identify stored custom
    36             settings and session data on the server. Although it is
    37             automatically generated by default, you may change it to something
    38             easier to remember at any time if you wish to load your settings
    39             in a different web browser.</p>
     36            <p class="hint" i18n:msg="">The session key is used to <!--!
     37            -->identify stored custom settings and session data on <!--!
     38            -->the server. Although it is automatically generated <!--!
     39            -->by default, you may change it to something easier <!--!
     40            -->to remember at any time if you wish to load your <!--!
     41            -->settings in a different web browser.</p>
    4042          </td>
    4143        </tr>
    4244        <tr class="field">
    … …  
    4951        <tr>
    5052          <th></th>
    5153          <td>
    52             <p class="hint">You may load a previously created session by enteri
    53             corresponding session key below. This lets you share settings betwe
    54             multiple computers and web browsers.</p>
     54            <p class="hint" i18n:msg="">You may load a previously <!--!
     55            -->created session by entering the corresponding session <!--!
     56            -->key below. This lets you share settings between <!--!
     57            -->multiple computers and web browsers.</p>
    5558          </td>
    5659        </tr>
    5760      </table>

However, the above patch prevents line breaks in the extracted message whereas just removing the indentation does not:

  • trac/prefs/templates/prefs_advanced.html 

    diff --git a/trac/prefs/templates/prefs_advanced.html b/trac/prefs/templates/pre
index 82fb2af..dc5ffae 100644
    a b  
    3232        <tr>
    3333          <th></th>
    3434          <td>
    35             <p class="hint">The session key is used to identify stored custom
    36             settings and session data on the server. Although it is
    37             automatically generated by default, you may change it to something
    38             easier to remember at any time if you wish to load your settings
    39             in a different web browser.</p>
     35            <p class="hint">
     36The session key is used to identify stored custom settings and
     37session data on the server. Although it is automatically generated
     38by default, you may change it to something easier to remember at
     39any time if you wish to load your settings in a different web
     40browser.</p>
    4041          </td>
    4142        </tr>
    4243        <tr class="field">
    … …  
    4950        <tr>
    5051          <th></th>
    5152          <td>
    52             <p class="hint">You may load a previously created session by enteri
    53             corresponding session key below. This lets you share settings betwe
    54             multiple computers and web browsers.</p>
     53            <p class="hint">
     54You may load a previously created session by entering the
     55corresponding session key below. This lets you share settings
     56between multiple computers and web browsers.</p>
    5557          </td>
    5658        </tr>
    5759      </table>

Does anyone have a preference?

Last edited 10 years ago by Ryan J Ollos (previous) (diff)

in reply to:  3 comment:6 by Ryan J Ollos, 10 years ago

Replying to psuter:

… Requested in #4263, #956, #1752.)

The issue with those two TracLinks is reported in #11816.

Last edited 10 years ago by Ryan J Ollos (previous) (diff)

comment:7 by Ryan J Ollos, 10 years ago

I'm seeing some strange behavior with the Git repository for the past few weeks. The log shows commits from the 0.12-stable branch: 

$ git log --oneline mirror/trunk
3f8b606 1.1.3dev: merged [13269] from 1.0-stable (fix for `WikiPageTestCase.test
2ca7f2f 0.12.7dev: fixed rare failure in `WikiPageTestCase.test_update_page`
c673034 1.1.3dev: merged [13266] from 1.0-stable (fix for #11797)
1f21f4a 1.1.3dev: record-only merge on [13264]
f4d466d 1.1.3dev: Merged [13262] from 1.0-stable. Refs #11813.
c563250 1.1.3dev: Merged [13260] from 1.0-stable. Refs #11612.
0dd3041 1.1.3dev: merged r13251 from 1.0-stable (`make status` improvements)
fc35fb8 0.12.7dev: use a script to display packages versions in `make status`
8b8f5c2 0.12.7dev: improve `make status` output

A simple interactive rebase with all of the revisions left as pick fails: 

$ git rebase -i HEAD~5
error: could not apply 2ca7f2f... 0.12.7dev: fixed rare failure in `WikiPageTestCase.test_update_page`

When you have resolved this problem, run "git rebase --continue".
If you prefer to skip this patch, run "git rebase --skip" instead.
To check out the original branch and stop rebasing, run "git rebase --abort".
Could not apply 2ca7f2f2bbb708bc6ead53b0c4218577dbc7ca82... 0.12.7dev: fixed rare failure in `WikiPageTestCase.test_update_page`

comment:8 by Ryan J Ollos, 10 years ago

Release Notes: modified (diff)
Status: new → assigned

Removed some unnecessary tbody tags in [13271:13272]. Improved alignment of elements on the Date & Time and Language preference panels in [13273:13276].

Last edited 10 years ago by Ryan J Ollos (previous) (diff)
Note: See TracTickets for help on using tickets.