Edgewall Software

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#11618 closed defect (fixed)

Manage Repositories page has `readonly="True"` attribute for repository defined in trac.ini — at Version 3

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 0.12.6
Component: version control Version: 0.12.5
Severity: minor Keywords:
Cc: Ryan J Ollos Branch:
Release Notes:

Fix malformed readonly="True" attributes in repositories and milestones admin pages with Genshi 0.6.1.

API Changes:
Internal Changes:

Description

Manage Repositories page has readonly="True" attribute for repository defined in trac.ini.

I think it must be readonly="readonly". 

          <div class="field">
            <label>Name:<br /><input type="text" name="name" class="trac-autofocus" value="" readonly="True" /></label>
          </div>
...
              <div class="field">
                <label>Directory:<br /><input type="text" name="dir" size="48" value="/var/svn/trac" readonly="True" /></label>
              </div>

Change History (3)

comment:1 by Ryan J Ollos, 10 years ago

Cc: Ryan J Ollos added

Just for reference, we encountered the issue previously in #11069 / [12026]. It looks like the issue should be fixed (​genshi:#570) for Genshi 0.6.2 / 0.7.1, but we'll need the workaround for now.

Last edited 10 years ago by Ryan J Ollos (previous) (diff)

comment:2 by Jun Omae, 10 years ago

Milestone: next-minor-0.12.x → 0.12.6
Owner: set to Jun Omae
Status: new → assigned

Thanks for the information. I noticed milestone admin in Trac 0.12 has the same issue and has been fixed in 1.0-stable on #11069 while working this issue.

Proposed changes in jomae.git@t11618_0.12 included fixes for milestone admin and jomae.git@t11618.

comment:3 by Jun Omae, 10 years ago

Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Committed to 0.12-stable in [12806] and merged to 1.0-stable in [12807] and trunk in [12808].

Note: See TracTickets for help on using tickets.