Edgewall Software

Changes between Initial Version and Version 1 of Ticket #11605, comment 11


Ignore:
Timestamp:
May 19, 2014, 6:35:05 PM (10 years ago)
Author:
Jun Omae

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11605, comment 11

    initial v1  
    11> If we need to be concerned about changing the signature of `_insert_changeset` then it should really be a public method. The whole point of making a method private is that it shouldn't be accessed by external components. So the plugins are wrong for accessing that method and expecting a contract to be adhered to in doing so. Practicality prevails though, so I agree that we shouldn't change the method. We should figure out an API change that could be made so that those plugins don't need to access a private method of the class.
    22
    3 Thanks. I think We could add `insert_changeset` without `db` parameter and mark `_insert_changeset` as "deprecated" like the following in this ticket. If the changes is applied, we keep compatibilities and external plugins can easyly detect the method with/without db parameter.
     3Thanks. I think We could add `insert_changeset` without `db` parameter and mark `_insert_changeset` as "deprecated" like the following in this ticket. If the changes is applied, we keep compatibilities and external plugins can easily detect the method with/without db parameter.
    44
    55{{{#!diff