Edgewall Software

Changes between Initial Version and Version 1 of Ticket #11512, comment 24


Ignore:
Timestamp:
Apr 18, 2014, 9:49:05 AM (10 years ago)
Author:
Jun Omae

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11512, comment 24

    initial v1  
    3434}}}
    3535
    36 I don't think that `drop_table()` should call `self.commit()`. Caller of the function should use `db_transaction()`.
     36I don't think that `drop_table()` should call `self.commit()`. Caller of the function should use `@with_transaction()`.
    3737
    3838Also, transaction in PostgresSQL can contain DDL, e.g. `CREATE TABLE`, `DROP TABLE` and can rollback. However, transaction in MySQL cannot contain DDL. See [https://wiki.postgresql.org/wiki/Transactional_DDL_in_PostgreSQL:_A_Competitive_Analysis Transactional DDL in PostgreSQL: A Competitive Analysis - PostgreSQL wiki].