Edgewall Software

Changes between Initial Version and Version 1 of Ticket #11369, comment 3


Ignore:
Timestamp:
Nov 23, 2013, 1:21:24 AM (10 years ago)
Author:
Ryan J Ollos

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #11369, comment 3

    initial v1  
    11There are at least two issues:
    2  * The [browser:/tags/trac-0.12.5/trac/notification.py@:319-323#L308 exception message] is wrapped in a pair of successive `p` tags. I think we can probably remove these.
     2 * The [browser:/tags/trac-0.12.5/trac/notification.py@:319-323#L308 exception message] is wrapped in a pair of successive `p` tags. I think we can probably remove these, particularly if the error will always be handled and displayed as a warning, which is the only case that I see.
    33 * The `Fragment` is serialized to a unicode string when doing string interpolation to construct another fragment: [browser:/tags/trac-0.12.5/trac/ticket/web_ui.py@:1250-1253#L1221]. This is why we end up with markup such as:
    44 {{{#!html
    … …  
    99}}}
    1010
    11 For the latter issue, I think we need to iterate over the `Fragment` and replace the ascii strings with unicode strings: log:rjollos.git:t11369. I still plan to do some more testing since I'm not sure of the change yet.
     11For the latter issue, I think we need to iterate over the `Fragment` and replace the ascii strings with unicode strings: log:rjollos.git:t11369. I still plan to do some more testing since I'm not confident of the change yet.
    1212
    1313Another issue, also related to #11368, is that it would be nice to strip out the markup when logging the error. That would make these errors more readable: