Edgewall Software

Opened 11 years ago

Last modified 10 years ago

#11297 closed enhancement

Allow root of repository to be specified for Git repository directory — at Initial Version

Reported by: Ryan J Ollos Owned by:
Priority: normal Milestone: 1.0.2
Component: plugin/git Version: 1.0-stable
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

If we have a Git repository in /home/user/Workspace/t11295/teo-rjollos.git/ and set the Directory through the web admin page to this path, we are initially given no indication that this is incorrect. When resyncing, there is a suggestions:

(t11295)user@ubuntu:~/Workspace/t11295$ trac-admin tracdev repository resync "Trac"
20:06:59 Trac[PyGIT] ERROR: GIT control files missing in '/home/user/Workspace/t11295/teo-rjollos.git/'
20:06:59 Trac[PyGIT] ERROR: entry '.git' found in '/home/user/Workspace/t11295/teo-rjollos.git/' -- maybe use that folder instead...
20:06:59 Trac[git_fs] ERROR: GitError: GIT control files not found, maybe wrong directory?
TracError: /home/user/Workspace/t11295/teo-rjollos.git/ does not appear to be a Git repository.

The path must point to the .git directory: /home/user/Workspace/t11295/teo-rjollos.git/.git. However, this might be confusing to someone that has worked with Trac and SVN, since we point Directory to the root of the SVN repository.

I can think of two different approaches that might improve on this:

  1. Show ERROR: entry '.git' found in … message through the web interface when saving the repository configuration.
  2. Just append .git to the path if needed rather than showing an error.

In the future I was hoping we could add a Resync button to the web interface, so while the suggestions in this ticket wouldn't be an enormous improvement in usability since the user has to move to the command line to do the resync, it would have greater benefit when/if all the operations could be done though the web interface.

Change History (0)

Note: See TracTickets for help on using tickets.