Context Navigation

Changes between Initial Version and Version 1 of Ticket #11286, comment 7

initial	v1
2	2	> Also, the functional tests call `setlocale` in `FunctionalTestEnvironment`.
3	3
4		Okay, I see that happens [browser:/tags/trac-1.0.1/trac/tests/functional/testenv.py@:61#L36 here]. I tried commenting out that line, leaving the session default `LC_ALL=C` and expected to see the #11291 test failure prior to [12020], but did not see that test fail on Linux. There were a few test failures associated with the milestone admin module.
	4	Okay, I see that happens [browser:/tags/trac-1.0.1/trac/tests/functional/testenv.py@:61#L36 here]. I tried commenting out that line, leaving the session default `LC_ALL='C'` and expected to see the #11291 test failure prior to [12020], but did not see that test fail on Linux. There were a few test failures associated with the milestone admin module.
5	5
6	6	The patch looks good to me. I noticed while experimenting that date formats other than iso8601 are allowed, such as timeline:12/31/01. This is because `parse_date` [browser:/tags/trac-1.0.1/trac/util/datefmt.py@:449-450#L440 tries] various formats. We could restrict this by passing `locale='iso8601'` to `parse_date`, but that doesn't seem necessary. Perhaps the current approach is best - suggesting iso8601 in the [TracLinks#timeline:links documentation] while allowing the other formats.