Changes between Version 1 and Version 2 of Ticket #11145, comment 16
- Timestamp:
- Jul 12, 2014, 11:14:24 PM (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #11145, comment 16
v1 v2 5 5 * After the proposed changes in #11474, `Chrome.show_email_addresses` will only be used outside the `Chrome` class in [browser:/trunk/trac/ticket/notification.py@12751:465#L460]. After #11474 is committed, we could simplify the API for plugins by deprecating `show_email_addresses` for removal from the Chrome data dictionary. 6 6 7 On a related note, there is some odd-looking code in the preparation of `show_email_addresses`. Does anyone have an idea of what type of Exceptions might be encountered here?: [browser:/trunk/trac/web/chrome.py@12930:878#L875]. The code was added in [8785 ].7 On a related note, there is some odd-looking code in the preparation of `show_email_addresses`. Does anyone have an idea of what type of Exceptions might be encountered here?: [browser:/trunk/trac/web/chrome.py@12930:878#L875]. The code was added in [8785#file4]. 8 8 9 9 There is a possible problem that became more clear after these changes. For whatever reason, the usernames are replaced with email addresses in the RSS feed when possible. However, `EMAIL_VIEW` permission is not checked when rendering the RSS feed. Only the `show_email_addresses` option is considered: [browser:/trunk/trac/web/chrome.py@12930:1118#L1115]. The email addresses won't be added to the map if `show_email_addresses` is `false` Is this a defect?