Edgewall Software

Opened 11 years ago

Last modified 5 years ago

#11112 closed enhancement

Apply hint/help classes more widely — at Version 6

Reported by: Ryan J Ollos <ryan.j.ollos@…> Owned by:
Priority: low Milestone: 1.3.3
Component: general Version:
Severity: minor Keywords: help
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description (last modified by Ryan J Ollos)

I like the styling of the hint and help classes, and have noticed some places that I think it could be appropriately applied.

Example of help class:

Change History (9)

by Ryan J Ollos <ryan.j.ollos@…>, 11 years ago

Attachment: ComponentAdminPanel.png added

comment:1 by Ryan J Ollos <ryan.j.ollos@…>, 11 years ago

Description: modified (diff)
Summary: Apply help class more widelyApply hint/help classes more widely

by Ryan J Ollos <ryan.j.ollos@…>, 11 years ago

Attachment: ReportEditPage.png added

comment:2 by Ryan J Ollos <ryan.j.ollos@…>, 11 years ago

Here is an example of the kind of changes I had in mind:

  • bef1f02e: Applied the hint class to text on the Report Edit page.
  • 7b72499e: Separated the label text and hint text, as I think this will allow theme authors to locate the hint independent from the placement of the label, without breaking translations.

Here is the result - the two lines to the right of the labels have a new styling:

by Ryan J Ollos <ryan.j.ollos@…>, 11 years ago

Attachment: ReportEditPageOrig.png added

comment:3 by Ryan J Ollos <ryan.j.ollos@…>, 11 years ago

Here is a screen capture of the current state of things, for comparison:

comment:4 by Ryan J Ollos <ryan.j.ollos@…>, 11 years ago

  • 61a40d63: Default padding for span.hint is 0, and padding of 1em for span.hint used on the Admin forms is set in admin.css..
  • 5ae38851: Moved p.help class from admin.css to trac.css, so that it can be used more widely within Trac.

comment:5 by Ryan J Ollos <ryan.j.ollos@…>, 11 years ago

I'll wait for feedback on the changes before coming up with a patch to implement these changes throughout Trac, but on first review, here is where changes would need to be made:

  • (you may use WikiFormatting here): on the following pages:
    • Milestone Edit
    • Ticket
    • Admin Ticket System and Admin Manage Repositories
  • Milestone Edit: Format: MM/DD/YYYY hh:mm:ss a should be wrapped in a span with class hint (like the Admin Milestone Edit page), rather than being wrapped in em, and the CSS rule for #edit em can be removed.

comment:6 by Ryan J Ollos, 11 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.