Edgewall Software

Changes between Version 1 and Version 2 of Ticket #11018, comment 5


Ignore:
Timestamp:
Oct 26, 2013, 12:20:00 AM (8 years ago)
Author:
Ryan J Ollos

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11018, comment 5

    v1 v2  
    1313 1. When a milestone is deleted or closed and the tickets are retargetted to the //None// milestone. When the milestone is deleted and tickets retargetted to //None//, the milestone will be set to `null` after [7581]. However, if the milestone is closed and ticket retargetted to //None//, the milestone will be set to the empty string.
    1414
    15 It looks to me like this needs to be fixed at the database level since `_fetch_ticket` will already replace `null`s with empty strings when **retrieving** ticket values. We just need to consistently store the data using whatever is chosen to represent the empty value. Due to (1), using the empty string as the empty value in the database would be a bit difficult. Since unset values in the database will remain `null`, it will be much easier to obtain consistency in the database by replacing empty strings with `None` before inserting into the ticket table. This might be accomplished by a patch as simple as the following (but needs more testing first):
     15It looks to me like this only needs to be fixed at the database level since `_fetch_ticket` will already replace `null`s with empty strings when **retrieving** ticket values. We just need to consistently store the data using whatever is chosen to represent the empty value. Due to (1), using the empty string as the empty value in the database would be a bit difficult. Since unset values in the database will remain `null`, it will be much easier to obtain consistency in the database by replacing empty strings with `None` before inserting into the ticket table. This might be accomplished by a patch as simple as the following (but needs more testing first):
    1616
    1717{{{#!diff