Opened 11 years ago
Last modified 10 years ago
#10978 closed defect
SVN `get_changes` performance issue — at Version 2
| Reported by: | michal.hankiewicz | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.12.6 |
| Component: | version control | Version: | 0.12-stable |
| Severity: | normal | Keywords: | svn memory performance |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description (last modified by )
Changes made in [11244] in file svn_fs.py is a performance killer.
Our plugin uses function get_changes and when dealing with bigger changesets Trac starts to consume huge amount of memory and get_changes takes ages to complete.
According to the log message change was made to fix failing tests, not because something was not working. We think that reverting this change and fixing tests is better idea than killing performance.
Note:
See TracTickets
for help on using tickets.
Well, there was another effect that wasn't mentioned in that other ticket: the change in SVN 1.7.x messed up the sorting of the file list in the changeset view. The fix restores a consistent order.
But we could also move the sorting to the UI code instead of keeping it in
get_changes(). Would you like to try and implement that?