[patch] TRAC DB flooded with useless entries

[Dirk Stöcker]

My trac database is flooded with lots of useless entries copying the default values. Especially as this is true for anonymous users the database really gets problems due to this. Below is a patch which prevents adding the timeline entries when they equal the defaults. This does not change beaviour of the software, but reduces required space.

The added 'ifs' simply tests if the new values equal the default and prevent storage. If different values are already stored, the default is nevertheless saved.

web_ui.

@@ -200 +200 @@
             data['context'] = rss_context                                                                                                                                                                     
             return 'timeline.rss', data, 'application/rss+xml'                                                                                                                                                
         else:                                                                                                                                                                                                 
-            req.session['timeline.daysback'] = daysback                                                                                                                                                       
-            req.session['timeline.authors'] = authors                                                                                                                                                         
+            if(as_int(req.session.get('timeline.daysback',                                                                                                                                                    
+            self.default_daysback), None) != daysback):                                                                                                                                                       
+                req.session['timeline.daysback'] = daysback                                                                                                                                                   
+            if(req.session.get('timeline.authors', '') != authors):                                                                                                                                           
+                req.session['timeline.authors'] = authors                                                                                                                                                     
             html_context = Context.from_request(req)
             html_context.set_hints(wiki_flavor='oneliner', 
                                    shorten_lines=self.abbreviated_messages)

[Remy Blank]

Replying to dstoecker:

This does not change beaviour of the software, but reduces required space.

That's not quite 100% true. It will change the behavior if the default values are changed in Trac at some point. This could actually be considered a feature.

[Dirk Stöcker]

Replying to rblank:

Replying to dstoecker:

This does not change beaviour of the software, but reduces required space.

That's not quite 100% true. It will change the behavior if the default values are changed in Trac at some point. This could actually be considered a feature.

True. Actually I would consider it a feature.