Edgewall Software

Changes between Initial Version and Version 1 of Ticket #10451, comment 7


Ignore:
Timestamp:
Dec 14, 2011, 11:22:30 PM (12 years ago)
Author:
osimons

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10451, comment 7

    initial v1  
    1 Looking at the trac-hacks changeset, would it not be sufficient to remove the line and not call `db.rollback()` at all? Just log the error, and then just call `raise` to propagate the error up the chain and let Trac upgrade routine deal with the error? It should do the necessary handling according to whatever logic prevails at the version in use.
     1Looking at the trac-hacks changeset, would it not be sufficient to remove the line and not call `db.rollback()` at all? Just log the error, and then just call `raise` to propagate the error up the chain and let Trac upgrade routine deal with the error? It should do the necessary handling according to whatever logic exists at the version in use.