#9607 closed enhancement (fixed)
Rework branch labeling in the timeline
| Reported by: | Christian Boos | Owned by: | Christian Boos |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.0 |
| Component: | version control | Version: | 0.13dev |
| Severity: | normal | Keywords: | branch tag label |
| Cc: | Branch: | ||
| Release Notes: |
Timeline: the changesets entries display their associated tags, if any |
||
| API Changes: |
versioncontrol: added |
||
| Internal Changes: | |||
Description (last modified by )
In #8843, we added the possibility to display the branch information for each changeset in the timeline.
However, it doesn't look that nice when we also display the list of changed files inline:
It would be better to show this label like the gitweb and the hg web interfaces do, after the changeset number, not on the next line.
A second (minor) issue with the above is that we always show the default label for Mercurial repositories. I ended up using a simple ignore list (default, master).
With display-branch-in-event-title-r9966.patch, we have:
A second step is to add support for displaying the tag labels.
With display-tags-in-changeset-events-r9966.patch, we have:
…
Attachments (6)
Change History (14)
by , 14 years ago
| Attachment: | timeline-8843.png added |
|---|
by , 14 years ago
| Attachment: | timeline-new-branch-labels.png added |
|---|
New layout for the branch labels
by , 14 years ago
| Attachment: | timeline-new-tag-labels-2.png added |
|---|
Show the tag labels (a bit further down in the history)
by , 14 years ago
| Attachment: | display-branch-in-event-title-r9966.patch added |
|---|
display branch name label in the timeline event's title line instead of its description. Applies on r10060.
by , 14 years ago
| Attachment: | display-tags-in-changeset-events-r9966.patch added |
|---|
display tag labels for the changeset events in the timeline. Applies on display-branch-in-event-title-r9966.patch.
comment:1 by , 14 years ago
| Description: | modified (diff) |
|---|
comment:3 by , 14 years ago
I don't have time to dive into the code ATM, but the result is very nice.
comment:4 by , 14 years ago
| API Changes: | modified (diff) |
|---|---|
| Release Notes: | modified (diff) |
| Resolution: | → fixed |
| Status: | new → closed |
Well, the code was cleaned up during the process of creating this ticket (I previously had some filtering arguments in get_branches() I was not fully convinced about), so my remaining question mark was more if you liked the final result ;-)
Applied in [10076:10077].
follow-up: 6 comment:5 by , 12 years ago
I noticed that branch timeline-displaying does not work for SVN commits, though it does with Mercurial commits; you can check that on the t.e.o timeline. Is there a ticket tracking this remaining issue?
follow-up: 7 comment:6 by , 12 years ago
Replying to fbrettschneider@…:
I noticed that branch timeline-displaying does not work for SVN commits
Right, it's not implemented for svn.
Is there a ticket tracking this remaining issue?
No, please create a feature request if you like (PatchWelcome applies ;-) ). Implementation hint: same code as for changeset_show_files=location, combined with matching on the patterns given in [svn] branches / tags.
follow-up: 8 comment:7 by , 12 years ago
(and btw, one of the reason it's not implemented is precisely because [timeline] changeset_show_files=location somehow already fills that need, you may want to have a try)
comment:8 by , 12 years ago
Replying to cboos:
… because
[timeline] changeset_show_files=locationsomehow already fills that need
Yes, it's perfect for me. Thanks for your hint.
Example for #8843, as it looks like in Trac 0.12