Regression: Non-numeric revision ids fail

[acg@…]

Follow-up to #6654 — which added 0 padding to SVN revision numbers. This breaks git and others. Suggest moving numeric formatting/cast code to svn_fs or similar?

[Remy Blank]

Could you please be more precise? Maybe post a link to the relevant ticket for the git plugin?

[John Hampton]

Regarding Git, the relevant ticket is ​th:#6554

I plan on merging Kevin's branch back into the Git plugin in the very near future.

[Remy Blank]

Ok, in retrospect it wasn't such a great idea to add the padding code to cache.py. I have a working patch that doesn't break the git plugin. Coming shortly.

[Christian Boos]

Replying to jhampton:

Regarding Git, the relevant ticket is ​th:#6554

I plan on merging Kevin's branch back into the Git plugin in the very near future.

Seems it has been merged already ​[TH7695].

So the question is, what kind of breakage do we have here, as the revision ids are still not numbers in the table itself, only strings made of zero-padded ints when inserted via the CachedRepository.

Looking in the plugin and git_fs.py, there's only a !CachedRepository2 subclass with very minimal changes, so no wonder this breaks. What we should have here is a refactoring of the CachedRepository that would have methods to properly encode the revision values when storing and retrieving them from the table. Actually, the CachedRepository itself should probably have no-ops there which should be fine for Git (and Hg!) and we should have a SvnCachedRepository which does the zero-padding.

I should probably do that while implementing #8417.

[Remy Blank]

The zero-padding for Subversion was refactored as suggested in [9280], and the git plugin works again.