Edgewall Software
Modify

Opened 5 years ago

Last modified 9 months ago

#8417 new defect

CachedRepository support in TracMercurial

Reported by: asterix@… Owned by: cboos
Priority: high Milestone: plugin - mercurial
Component: plugin/mercurial Version: 0.11.1
Severity: critical Keywords: mercurial changeset
Cc: awagner@…, richard.liao.i@…, bkocherov@…, miguel.araujo.perez@…, ismael@…, macke@…, me@…, leho@…, dev@…
Release Notes:
API Changes:

Description

I used trac with svn, and switched to mercurial. the revision table in postgres is no more updated with new changesets. So when I do a search in changesets, new changesets are not listed. Did I forgot to configure something?

Attachments (6)

backend.py (57.2 KB) - added by me@… 3 years ago.
I have implemented a naive version of MecrurialCachedRepository? using a backward-traversing resync which overrides the default resync algorithm.
backend.py.patch (13.4 KB) - added by me@… 3 years ago.
And this is the diff.
backend.2.py (54.6 KB) - added by me@… 3 years ago.
Revised patch: applied the set diff algorithm by miguel.araujo.perez and now ticket commit updater works correctly
backend.py.2.patch (10.9 KB) - added by me@… 3 years ago.
Diff for the revised patch
backend.3.py (55.1 KB) - added by me@… 3 years ago.
Revised again: error handling & branch display in the timeline
backend.py.3.patch (11.4 KB) - added by me@… 3 years ago.
Diff for the revised patch

Download all attachments as: .zip

Change History (23)

comment:1 Changed 5 years ago by cboos

  • Milestone set to not applicable
  • Priority changed from normal to high
  • Severity changed from normal to major

No, I forgot to implement it ;-)

More seriously, TracMercurial works quite well now even for big repositories, without a cache.

However the cache would be needed for enabling the search in changesets and for getting faster and more accurate results for the timeline, so it's about time this gets implemented…

comment:2 Changed 5 years ago by cboos

  • Summary changed from revision table not updated to CachedRepository support in TracMercurial

comment:3 Changed 5 years ago by cboos

  • Milestone changed from not applicable to mercurial-plugin
  • Severity changed from major to critical

comment:4 Changed 4 years ago by awagner@…

  • Cc awagner@… added

comment:5 Changed 4 years ago by richard.liao.i@…

  • Cc richard.liao.i@… added

comment:6 Changed 4 years ago by miguel.araujo.perez@…

I have developed a plugin called TracMercurialChangesetPlugin? for fixing this issue. It allows you to sync revision table if you are using Mercurial. Then you can create a hook to keep it synced :) I hope it helps. I have mailed cboos about it, see If he can integrate into Trac-Mercurial.

http://github.com/maraujop/TracMercurialChangesetPlugin

comment:7 Changed 4 years ago by bkocherov@…

2miguel.araujo.perez

That do you think about use FULLHASH as 'rev' in opposite

NUMBER:SHORTHASH? I think only fullhash real unique. If repository very distributed then in different placess world changesets can be different NUMBER.

comment:8 Changed 4 years ago by Boris Kocherov <bkocherov@…>

  • Cc bkocherov@… added

comment:9 Changed 4 years ago by Miguel Araujo <miguel.araujo.perez@…>

  • Cc miguel.araujo.perez@… added

comment:10 Changed 4 years ago by Ismael de Esteban <ismael@…>

  • Cc ismael@… added

comment:11 Changed 4 years ago by Marcus Lindblom <macke@…>

  • Cc macke@… added

comment:12 Changed 3 years ago by cboos

  • Cc me@… added

#10135 was closed as duplicate.

Changed 3 years ago by me@…

I have implemented a naive version of MecrurialCachedRepository? using a backward-traversing resync which overrides the default resync algorithm.

Changed 3 years ago by me@…

And this is the diff.

comment:13 Changed 3 years ago by me@…

The above version is not complete yet. It's quick & dirty demo.

I'm inspecting its bug(?) that newly commited/pushed changesets are not synced correctly after the resync, as well as ticket commit updates.

Changed 3 years ago by me@…

Revised patch: applied the set diff algorithm by miguel.araujo.perez and now ticket commit updater works correctly

Changed 3 years ago by me@…

Diff for the revised patch

Changed 3 years ago by me@…

Revised again: error handling & branch display in the timeline

Changed 3 years ago by me@…

Diff for the revised patch

comment:14 Changed 3 years ago by lkraav <leho@…>

  • Cc leho@… added

comment:15 Changed 3 years ago by Joongi Kim <me@…>

The remaining issue:

  • We need some efficient implementation like hg incoming/outgoing to find out which changesets should be synchronized. (The current "whole set comparison" would not scale well with very large repositories with more than 10k changesets.)

One mistake: must delete import pdb; pdb.set_trace() in line 744 of the patched backend.py before applying the patch to the trunk.

comment:16 Changed 3 years ago by Joongi Kim <me@…>

Another idea:

  • Currently CachedRepository only have one sync() method which is called by both 'resync' and 'commit ticket updater'. For the latter case, we can use hints from the commit ticket updater to determine which revisions should be synchronized since they are given as the command line arguments. We do not have to the same thing twice. We could add optional arguments to sync() method to handle it.

comment:17 Changed 10 months ago by dev@…

  • Cc dev@… added

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as new The owner will remain cboos.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from cboos to anonymous. Next status will be 'assigned'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.