Milestone insert() method is not updating _old_name member

[Andrea Tomasini <andrea.tomasini@…>]

The current Milestone insert() method is not updating the _old_name member, therefore it is not possible to create and update a milestone without closing it and reopening it. I understand that is not vital to trac, as apparently the creation and the updates are done in different requests, but is an error in the model integrity.

The patch is deadly simple:

Index: trac/ticket/model.py
===================================================================
--- trac/ticket/model.py	(revision 8744)
+++ trac/ticket/model.py	(working copy)
@@ -693,7 +693,8 @@
                       "VALUES (%s,%s,%s,%s)",
                       (self.name, to_timestamp(self.due), to_timestamp(self.completed),
                        self.description))
-
+        self._old_name = self.name
+        
        if handle_ta:
            db.commit()
        TicketSystem(self.env).reset_ticket_fields()

[Remy Blank]

I'll do that later tonight.

[Remy Blank]

Actually, not only milestones, but also components and versions exhibited the same issue. I have added test cases for this use case and fixed the issue in [8811].

Thanks for the bug report and the solution!