Ticket #8816 (closed defect: fixed)
Opened 2 years ago
Last modified 2 years ago
Rename a milestone instead of create a new one.
| Reported by: | Sondoar <ismael@…> | Owned by: | niels.reedijk@… |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.11.7 |
| Component: | roadmap | Version: | 0.11.5 |
| Severity: | normal | Keywords: | milestone rename patch |
| Cc: | niels.reedijk@… | ||
| Release Notes: | |||
| API Changes: | |||
Description (last modified by cboos) (diff)
Steps:
- Create a new milestone with an existing milestone name.
- After the warning of there is already an existing milestone with that name, I change the name to a new one, and submit.
- Then trac renames the old milestone name to the new one. And there is no new milestone created.
Trac: 0.11.5 Python: 2.5.4 (r254:67916, Apr 4 2009, 17:56:17) [GCC 4.3.3] setuptools: 0.6c9 SQLite: 3.6.10 pysqlite: 2.5.0 Genshi: 0.5.1 Pygments: 0.10 Subversion: 1.4.6 (r28521) jQuery: 1.2.6
Attachments
Change History
comment:1 Changed 2 years ago by rblank
- Milestone set to 0.11.6
- Owner set to rblank
comment:2 Changed 2 years ago by rblank
- Milestone changed from 0.11.6 to 0.11.7
0.11.6 is about to start testing, so we'll do that in the next release.
Changed 2 years ago by niels.reedijk@…
- Attachment trac-#8861-milestone-create.patch added
Patch for this problem
comment:3 Changed 2 years ago by anonymous
Re: my patch
I'm not sure whether the logic of doing the milestone rename is clear from the flow of the code, so perhaps it needs a comment to point that out.
comment:4 follow-up: ↓ 5 Changed 2 years ago by niels.reedijk@…
- Cc niels.reedijk@… added
- Keywords patch added
Add patch keyword (and sort of an attempt to 'bump' the patch)
comment:5 in reply to: ↑ 4 ; follow-up: ↓ 6 Changed 2 years ago by cboos
- Description modified (diff)
Replying to niels.reedijk@…:
Add patch keyword (and sort of an attempt to 'bump' the patch)
The "perfect" way to bump such a patch would be to add a functional test for it ;-)
See source:branches/0.11-stable/trac/ticket/tests/functional.py.
Changed 2 years ago by niels.reedijk@…
- Attachment trac-#8861-functional-test.patch added
Functional test
comment:6 in reply to: ↑ 5 Changed 2 years ago by niels.reedijk@…
Replying to cboos:
Replying to niels.reedijk@…:
Add patch keyword (and sort of an attempt to 'bump' the patch)
The "perfect" way to bump such a patch would be to add a functional test for it ;-)
Here you are. As expected, it fails before the patch (because the original milestone disappeared) and it succeeds after the patch.
Enjoy!
comment:7 Changed 2 years ago by rblank
- Resolution set to fixed
- Status changed from new to closed
Patch applied in [9052]. Thanks!
comment:8 Changed 2 years ago by rblank
- Owner changed from rblank to niels.reedijk@…
Ooh, bad! Confirmed here on 0.11-stable.