Edgewall Software
Modify

Opened 15 years ago

Closed 15 years ago

#8484 closed defect (fixed)

'Assign to' field should be labeled 'Set Owner'

Reported by: Ryan Ollos <ryano@…> Owned by: Christian Boos
Priority: normal Milestone: 0.12
Component: ticket system Version: 0.11
Severity: minor Keywords: workflow
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

I'm opening this as a bug, though I think it is most properly characterized as an ambiguity. Perhaps it should be an enhancement (or perhaps I am just the only one that thinks this is a problem)!

According to the default Trac workflow, all tickets are created with the default Status new. From TracWorkflow#BasicTicketWorkflowCustomization:

There are a couple of hard-coded constraints to the workflow. In particular, tickets are created with status new, and tickets are expected to have a closed state.

The act of Assigning a ticket sets its status to Assigned. However, on ticket creation, there is a box that Sets the Owner which is labeled Assign to:.

I think it would be more technically correct to label this box Set Owner. It is, after all, Setting the Owner, not Assigning the Ticket.

I posted this on the Trac user discussion list (1), but I didn't get any responses. If anyone has recommendations for modifying this behavior as I described in my posting, please let me know.

I've searched through the Trac tickets (2) and have not found that anyone else opened a report for this, which surprises me.

Attachments (0)

Change History (10)

comment:1 by Christian Boos, 15 years ago

Keywords: workflow added
Milestone: 0.12
Priority: lownormal

I'm ok with that change. Others?

comment:2 by Remy Blank, 15 years ago

+1

in reply to:  1 comment:3 by Emmanuel Blot, 15 years ago

Replying to cboos:

I'm ok with that change. Others?

As long as the internal API does not change (to "assign" a ticket to an owner), I'm ok as well.

comment:4 by Christian Boos, 15 years ago

Owner: set to Christian Boos

I'm not sure what you're referring to by internal API to assign a ticket to an owner, but IIUC the change would be simply:

  • trac/ticket/web_ui.py

    diff --git a/trac/ticket/web_ui.py b/trac/ticket/web_ui.py
    a b  
    11331133                type_ = field['type']
    11341134                field['skip'] = True
    11351135                if not ticket.exists:
    1136                     field['label'] = _('Assign to')
     1136                    field['label'] = _('Owner')
    11371137                    if 'TICKET_MODIFY' in req.perm(ticket.resource):
    11381138                        field['skip'] = False
    11391139                        owner_field = field

(Owner rather than Set owner, for consistency with the label for other fields)

[fr_FR] note: currently translated by "Propriétaire" … I'd rather see "Responsable" here.

in reply to:  4 comment:5 by Emmanuel Blot, 15 years ago

Replying to cboos:

I'm not sure what you're referring to by internal API to assign a ticket to an owner,

ticket = Ticket(self.env, ticket_id)
ticket['owner'] = u'john.doe'

[fr_FR] note: currently translated by "Propriétaire" … I'd rather see "Responsable" here.

+1

comment:6 by Remy Blank, 15 years ago

What about the workflow action "reassign to"? Shouldn't that be changed to "set owner to"?

comment:7 by Christian Boos, 15 years ago

"reassign" is the workflow transition name, and "to …" gets appended to it. See render_ticket_action_control in source:trunk/trac/ticket/default_workflow.py@8380.

Not very i18n friendly anyway, but we have already a ticket for that I think (#6234#5441, the latter should probably be widened in scope to cover all the places status transition names are displayed in the interface).

in reply to:  6 comment:8 by Ryan Ollos <ryano@…>, 15 years ago

Replying to rblank:

What about the workflow action "reassign to"? Shouldn't that be changed to "set owner to"?

If I understand correctly, reassign to changes the owner and puts the ticket in the assigned state; so the term reassign to seems appropriate here.

My issue with using assign to on ticket creation is that the owner is set, but the ticket is not assigned.

in reply to:  4 comment:9 by Ryan Ollos <ryano@…>, 15 years ago

Replying to cboos:

(Owner rather than Set owner, for consistency with the label for other fields)

Yeah that sounds good. Owner makes more sense and is more consistent than Set Owner.

comment:10 by Christian Boos, 15 years ago

Resolution: fixed
Status: newclosed

Change from comment:4 applied in r8386.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.