put save before cancel in admin forms

[gsf@…]

The current behavior for many of the forms in WebAdmin is unexpected, at least in Firefox. When one hits the enter key, it cancels instead of submitting because the cancel button comes before the submit button. This patch flips them around.

[gsf@…]

save before cancel patch

[gsf@…]

Note that this is a patch on core, not the WebAdmin plugin.

[anonymous]

Maybe there should also be a reset button, to revert the currently made changes..

[eblot]

Replying to anonymous:

Maybe there should also be a reset button, to revert the currently made changes..

I don't think it is worth cluttering the interface with a rarely used function that can be executed anyway with a simple page refresh.

[gsf@…]

new diff to handle i18n changes

[rblank]

There's a consistency issue here: all forms in Trac have a non-committing action as the default ("Preview" for wiki an ticket, "Cancel" for admin, etc.). This also avoids triggering "dangerous" actions inadvertently with ENTER.

I would say that this is a good thing (tm).

[gsf@…]

I'd say there's a big difference between preview and cancel, and cancel should never be the default action on a form, but I'll leave this at wontfix.