Ticket #6521 (closed defect: wontfix)
Opened 4 years ago
Last modified 3 years ago
put save before cancel in admin forms
| Reported by: | gsf@… | Owned by: | cmlenz |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | admin/web | Version: | devel |
| Severity: | normal | Keywords: | |
| Cc: | |||
| Release Notes: | |||
| API Changes: | |||
Description
The current behavior for many of the forms in WebAdmin is unexpected, at least in Firefox. When one hits the enter key, it cancels instead of submitting because the cancel button comes before the submit button. This patch flips them around.
Attachments
Change History
Changed 4 years ago by gsf@…
- Attachment save_cancel.diff added
comment:1 Changed 4 years ago by gsf@…
Note that this is a patch on core, not the WebAdmin plugin.
comment:2 follow-up: ↓ 3 Changed 4 years ago by anonymous
Maybe there should also be a reset button, to revert the currently made changes..
comment:3 in reply to: ↑ 2 Changed 4 years ago by eblot
Replying to anonymous:
Maybe there should also be a reset button, to revert the currently made changes..
I don't think it is worth cluttering the interface with a rarely used function that can be executed anyway with a simple page refresh.
Changed 4 years ago by gsf@…
- Attachment save_cancel_i18n.diff added
new diff to handle i18n changes
comment:4 Changed 3 years ago by rblank
- Resolution set to wontfix
- Status changed from new to closed
There's a consistency issue here: all forms in Trac have a non-committing action as the default ("Preview" for wiki an ticket, "Cancel" for admin, etc.). This also avoids triggering "dangerous" actions inadvertently with ENTER.
I would say that this is a good thing (tm).
comment:5 Changed 3 years ago by gsf@…
I'd say there's a big difference between preview and cancel, and cancel should never be the default action on a form, but I'll leave this at wontfix.
save before cancel patch