Edgewall Software
Modify

Ticket #5898 (closed defect: worksforme)

Opened 4 years ago

Last modified 11 months ago

Wrong req.redirect in process_admin_request

Reported by: airadier@… Owned by: cmlenz
Priority: normal Milestone:
Component: admin/web Version: devel
Severity: normal Keywords:
Cc: thijstriemstra
Release Notes:
API Changes:

Description

When using req.redirect method in process_admin_request, like:

req.redirect(self.env.href.admin(cat, page))

the browser is redirected to:

http://host/admin/cat/page

instead of

http://host/trac/project/admin/cat/page

(so the "trac/project" part is missing).

Attachments

Change History

comment:1 follow-up: Changed 4 years ago by cboos

  • Keywords verify added
  • Milestone changed from 0.11 to not applicable

This is related to the [trac] base_url setting which is missing, see #5064.

Anyway, the redirect should do req.redirect(req.href.admin(cat, page)) (req.href, not self.env) and that's what the admin module does in the trunk.

The WebAdmin plugin for 0.10 used to (still has?) that problem, though.
Needs to be verified and eventually fixed.

comment:2 in reply to: ↑ 1 Changed 11 months ago by thijstriemstra

  • Cc thijstriemstra added
  • Keywords verify removed
  • Resolution set to worksforme
  • Status changed from new to closed

Replying to cboos:

Anyway, the redirect should do req.redirect(req.href.admin(cat, page)) (req.href, not self.env) and that's what the admin module does in the trunk.

Closing it in that case.

comment:3 Changed 11 months ago by rblank

  • Milestone not applicable deleted
View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from cmlenz. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.