Edgewall Software
Modify

Ticket #3969 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

TypeError: an integer is required

Reported by: goldent Owned by: cboos
Priority: normal Milestone: 0.10.1
Component: version control/browser Version: devel
Severity: trivial Keywords:
Cc:
Release Notes:
API Changes:

Description

How to Reproduce

While doing a GET operation on /changeset/102, Trac issued an internal error.

System Information

Python 2.4.3 (#69, Mar 29 2006, 17:35:34) [MSC v.1310 32 bit (Intel)]
Subversion 1.4.0
SQLite 3.3.6
pysqlite 2.3.2

Python Traceback

Traceback (most recent call last):
  File "c:\python24\Lib\site-packages\trac\web\main.py", line 377, in dispatch_request
    dispatcher.dispatch(req)
  File "c:\python24\Lib\site-packages\trac\web\main.py", line 237, in dispatch
    resp = chosen_handler.process_request(req)
  File "c:\python24\Lib\site-packages\trac\versioncontrol\web_ui\changeset.py", line 249, in process_request
    self._render_html(req, repos, chgset, restricted, message, data)
  File "c:\python24\Lib\site-packages\trac\versioncontrol\web_ui\changeset.py", line 467, in _render_html
    diffs = _content_changes(old_node, new_node)
  File "c:\python24\Lib\site-packages\trac\versioncontrol\web_ui\changeset.py", line 435, in _content_changes
    ignore_space_changes=ignore_space)
  File "c:\python24\Lib\site-packages\trac\versioncontrol\diff.py", line 176, in diff_blocks
    line = line.expandtabs(tabwidth)
TypeError: an integer is required


Attachments

Change History

comment:1 Changed 5 years ago by mail@…

I'm using the current Subversion HEAD (r3996) and this error apparently happens on any attempt to access a /changeset URL

comment:2 Changed 5 years ago by cboos

  • Milestone set to 0.11
  • Severity changed from normal to minor

Looks like you have neither of those options set in your TracIni:

[diff]
tab_width = ...

[mimeviewer]
tab_width = ...

but we should probably default to '8' in this case.

comment:3 follow-up: Changed 5 years ago by cboos

  • Resolution set to fixed
  • Severity changed from minor to trivial
  • Status changed from new to closed

Fixed by r3998.

comment:4 in reply to: ↑ 3 ; follow-up: Changed 5 years ago by anonymous

Replying to cboos:

Fixed by r3998.

Thank you so much. I couldn't believe how fast that fix was. In fact my trac.ini had a tab_width = <blank> entry, which I've now set in any case.

comment:5 in reply to: ↑ 4 Changed 5 years ago by cboos

Replying to anonymous:

... In fact my trac.ini had a tab_width = <blank> entry, which I've now set in any case.

was that a newly created env, or because you set it like that by mistake?

comment:6 Changed 5 years ago by cboos

  • Milestone changed from 0.11 to 0.10.1

Ported to 0.10-stable in r4016.

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from cboos. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.