Ticket #3968 (closed defect: fixed)
TicketQueryMacro should not enforce order-id
| Reported by: | ilias@… | Owned by: | cboos |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.11 |
| Component: | ticket system | Version: | devel |
| Severity: | normal | Keywords: | |
| Cc: |
Description
The TicketQueryMacro uses default-order "id"
source:trunk/trac/ticket/query.py#3882#L720
kwargs.setdefault('order', 'id')
This line does not just set an default. It overrides an existent query parameter "&order=<field>".
It would be of benefit to remove the line completely, thus the original behaviour of the ticket query becomes available within the wiki (currently: order=priority).
This would lead to a more consistent design.
You can test the behaviour by adding this code to a wiki page:
testing order=type '''keyword-parameter''' [[TicketQuery(status=assigned|new|reopened, order=type, format=table )]] '''query-parameter''' [[TicketQuery(status=assigned|new|reopened&order=type, format=table)]]
context: http://dev.lazaridis.com/base/wiki/PlanTicketQueryMacro
Attachments
Change History
comment:1 follow-up: ↓ 2 Changed 4 years ago by cboos
- Owner changed from jonas to cboos
- Milestone set to 0.11
comment:2 in reply to: ↑ 1 Changed 4 years ago by ilias@…
Replying to cboos:
Ilias, are you color-blind? Really, please take no offense, but I can hardly stand the mix of olive green and white background you have on your Trac site ;)
criticism is always welcome.
I've changed it to the value trac uses, although I'm not sure if that's better. I've not yet reached the point where I hand-over this task where it belongs too: to a graphic designer. I promise this will happen within... the next year!
comment:3 follow-up: ↓ 5 Changed 4 years ago by cboos
- Status changed from new to closed
- Resolution set to fixed
Fixed in r3999, thanks for the report!
Concerning the TicketQueryin? general, I have a few more pending changes (datetime fixes and being able to select the columns in the output).



Ilias, are you color-blind? Really, please take no offense, but I can hardly stand the mix of olive green and white background you have on your Trac site ;)
Besides this little off-topic COSMETIC issue, I fully agree with you.