Edgewall Software
Modify

Opened 8 years ago

Closed 5 years ago

Last modified 5 years ago

#3865 closed defect (fixed)

Document migration to site.html

Reported by: sam@… Owned by: shanec@…
Priority: normal Milestone: 0.11.5
Component: general Version: devel
Severity: normal Keywords: initenv inherit patch
Cc: m@…, trudolphi@…, rysiek@…
Release Notes:
API Changes:

Description

The files in env/templates/... are not used, thus making CSS or templates tweaks per-environment impossible with latest Trac trunk. This is clearly a regression from previous revisions.

Attachments (1)

disable_env_site_template.patch (663 bytes) - added by shanec@… 6 years ago.
only create site.html if one is not in shared template path

Download all attachments as: .zip

Change History (15)

comment:1 Changed 8 years ago by cboos

Strange, seems to be still there, in Chrome's get_templates_dir.

comment:2 follow-up: Changed 8 years ago by cmlenz

  • Priority changed from high to normal
  • Severity changed from major to normal

Well, the Clearsilver site_*.cs are no longer used if the page is being rendered using Genshi. Instead, env/templates/site.html is being included if it's present.

We obviously need to add some upgrade instructions for guiding with the migration here.

comment:3 in reply to: ↑ 2 Changed 8 years ago by Markus Tacker <m@…>

  • Cc m@… added

Replying to cmlenz:

We obviously need to add some upgrade instructions for guiding with the migration here.

Yes, please do so!

comment:5 Changed 8 years ago by cmlenz

  • Keywords documentation added
  • Owner changed from jonas to cmlenz
  • Status changed from new to assigned
  • Summary changed from User templates not loaded to Document migration to site.html

And this post, which would be a starting point for updates to TracInterfaceCustomization.

comment:6 Changed 8 years ago by Markus Tacker <m@…>

  • Cc trudolphi@… added

comment:7 Changed 7 years ago by cboos

  • Milestone changed from 0.11.1 to 0.11
  • Resolution set to fixed
  • Status changed from assigned to closed

I believe this was fixed by r5703.

Changed 6 years ago by shanec@…

only create site.html if one is not in shared template path

comment:8 Changed 6 years ago by shanec@…

  • Resolution fixed deleted
  • Status changed from closed to reopened

I ran into an issue where the shared template site.html *was not* being used. When creating an environment, a site.html file is written out into env/template. If I remove that, the shared site.html is used. The patch I just attached does not write out a env/template/site.html if one exists in the shared template dir.

comment:9 Changed 6 years ago by cboos

  • Keywords initenv inherit added; documentation removed
  • Milestone changed from 0.11 to 0.11.3

Seems in line with what we do for other settings when using the --inherit flag for creating new environments (TracAdmin#Notes).

Rescheduling to 0.11.3, for integrating attachment:disable_env_site_template.patch.

comment:10 Changed 6 years ago by rysiek@…

  • Cc rysiek@… added

I second what shanec@… said - env/templates/site.html is clearly not needed (deleted site.html, had no global either), hence it's creation during initenv is superfluous - and as it causes problems when creating a global site.html file (I ran into the very same thing - created the global site.html and started debugging why isn't it used, only to find the default site.html in project env dirs).

I'd say it shouldn't be created in the first place anyway.

comment:11 Changed 6 years ago by cboos

  • Keywords patch added
  • Milestone changed from 0.11.6 to 0.11.5

comment:12 Changed 5 years ago by rblank

  • Owner changed from cmlenz to rblank
  • Status changed from reopened to new

comment:13 Changed 5 years ago by rblank

  • Resolution set to fixed
  • Status changed from new to closed

Patch applied in [8147]. Thanks!

comment:14 Changed 5 years ago by rblank

  • Owner changed from rblank to shanec@…

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed The owner will remain shanec@….
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from shanec@… to the specified user.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.