Edgewall Software

Ticket #2635 (closed enhancement: fixed)

Opened 3 years ago

Last modified 5 months ago

wiki link to go to wiki differences

Reported by: Dave Matthews Owned by: cboos
Priority: normal Milestone: 0.11
Component: wiki system Version: 0.9.3
Severity: normal Keywords:
Cc: daved@…, cboos

Description (last modified by cboos) (diff)

Currently you can refer to particular versions of wiki pages using #, e.g. TracLinks#16 (although this is not documented in TracLinks and is inconsistent with the @ syntax now used for source links). However, I am not aware of any way to link to the changes made to a wiki page at a particular version. This would be useful to be able to refer to from tickets in the same way that we can already refer to source changesets.


Note: I think what's really important in this request is the ability to identify some particular change to a wiki page.

Therefore I think that being able to specify a given revision (using "@", not "#" as written above) is what really matters here.

Attachments

Change History

  Changed 3 years ago by anonymous

  • type changed from defect to enhancement

  Changed 3 years ago by mgood

The example above of TracLinks#16 only puts an anchor on the URL, it doesn't link to that version.

  Changed 3 years ago by Dave Matthews

Yes, of course - sorry, don't know where I got that idea. In that case, the ability to link to particular versions of wiki pages could be useful as well.

  Changed 3 years ago by cboos

  • keywords tracobject added
  • owner changed from jonas to cboos

Being able to link to a specific wiki version (e.g. WikiStart@13) would be a good idea.

But actually there would be two possible targets:

  • the object as it looked like at a specific version (e.g. WikiStart@13, the wiki page as it was at version 13, what you can see here
  • the actual difference from one version to the previous one (e.g. WikStart@13:12 from version 13 to version 12, what you can see here. For an alternative visualization proposal, see the discussion in #2165.

See also #2168 for a proposal for adding more uniform treatment to TracLinks.

As part of the TracObjectModelProposal, I think that every Trac Object could be seen as a versioned resource, and in this case, it should be possible to address that history in a consistent way (both for the version retrieval and the view of the change).

  Changed 3 years ago by stevegt

I'm going to need to implement the WikiStart@13 syntax to support http://trac-hacks.org/wiki/WikiWorkflowPatch -- any preferences as to whether I include it in that patch, or as a separate standalone plugin?

  Changed 3 years ago by stevegt@…

After poking at this for a while, I'm beginning to thing that WikiStart.13 might be a much better syntax; the application I'm working on will cause that string to be seen and typed a lot, often by less-technical folks. While I agree there's precedent for that '@' sign, it's ugly as heck... I'm tentatively planning to implement this as WikiStart.13 and WikiStart.13:14 instead; still not decided on patch or plugin.

  Changed 3 years ago by anonymous

s/thing/think/

  Changed 3 years ago by anonymous

  • cc daved@… added

  Changed 2 years ago by cboos

  • keywords tracobject removed
  • status changed from new to assigned
  • summary changed from Can't create wiki link to wiki differences to wiki link to go to wiki differences
  • description modified (diff)
  • milestone set to 0.11

Now with r4370, the syntax proposed in comment:4 is implemented.

With this and the ability to quickly go to the actual changes from the displayed version using the Last Change link, I don't think it's still worth to have an explicit TracLinks syntax for accessing the differences directly... this seems a bit overkill.

Now, what can eventually be adapted is what should we preferably show when clicking on a "WikiStart@2" link: that given version (as it is currently done in r4370) or the diffs from that version to the previous one? In either case, the other view is one click away...

So let me know if you prefer the alternative or if things are now OK like that.

(Sorry stevegt about the choice of "@" over ".": I favored consistency. Besides, this keeps open the possibility that one day we'll support digits and dots in WikiPageNames, i.e. #425)

follow-up: ↓ 14   Changed 2 years ago by Dave Matthews

I think that the "@" syntax should refer to the specific version and not the changes to be consistent with how it is used in "source:" links.

Now that there is a Last Change link I agree that a further syntax to support direct links to the changes is probably overkill so I'm happy.

Thanks.

  Changed 2 years ago by cboos

  • status changed from assigned to closed
  • resolution set to fixed

Good, thanks for the confirmation.

  Changed 9 months ago by matt_callaghan@…

  • cc cboos added
  • status changed from closed to reopened
  • resolution fixed deleted

Interesting ...

I'm not sure if this warrants a re-open, but we're running version 10.4 and this proposed syntax as mentioned in comment 4 doesn't seem to work.

Also, what about this Wiki pages that do NOT follow camel case (i.e. acronyms) and require the

[wiki:MYACRONYM]

syntax?

Would:

[wiki:MYACRONYM@##]

work?

Thanks in advance,

  Changed 9 months ago by cboos

  • status changed from reopened to closed
  • resolution set to fixed

Sorry, this is only a 0.11 feature, as written in comment:9.

And yes, [wiki:MYACRONYM@##] will work as expected (even wiki:MYACRONYM@##, [wiki:MYACRONYM@## label] and ["MYACRONYM@##"], see WikiPageNames).

in reply to: ↑ 10 ; follow-up: ↓ 15   Changed 7 months ago by cboos

  • status changed from closed to reopened
  • resolution fixed deleted

Replying to Dave Matthews:

I think that the "@" syntax should refer to the specific version and not the changes to be consistent with how it is used in "source:" links. Now that there is a Last Change link I agree that a further syntax to support direct links to the changes is probably overkill so I'm happy.

There's a regression right now about this (no Last Change link in the Wiki version page), reopening this ticket as a reminder.

in reply to: ↑ 14 ; follow-up: ↓ 16   Changed 7 months ago by cboos

  • status changed from reopened to closed
  • resolution set to fixed

There's a regression right now about this (no Last Change link in the Wiki version page)

Fixed in r7028.

in reply to: ↑ 15   Changed 6 months ago by cboos

  • status changed from closed to reopened
  • resolution fixed deleted

Replying to cboos:

There's a regression right now about this (no Last Change link in the Wiki version page)

Fixed in r7028.

I'm still not happy with this, will revert.

  Changed 5 months ago by cboos

  • status changed from reopened to closed
  • resolution set to fixed
  • milestone changed from 0.11.1 to 0.11

Well, perhaps not 100% happy, but the current status will do ;-)

Add/Change #2635 (wiki link to go to wiki differences)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from cboos. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.