Edgewall Software
Modify

Ticket #2408 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

Email notification to reporters is broken

Reported by: dbrocher@… Owned by: eblot
Priority: high Milestone: 0.9.4
Component: ticket system Version: 0.9
Severity: normal Keywords: email notification reporter
Cc: dbrocher@…
Release Notes:
API Changes:

Description

Setting always_notify_reporter = true is meant to send notification emails for ticket changes to the original author of the ticket and also every author of a ticket change. The latter doesn't work in version 0.9. The bug has been introduced in changeset [1343], where the following code starting at line 294 in Notify.py

    cursor.execute('SELECT DISTINCT author,ticket FROM ticket_change ' 
                   ' WHERE ticket=%s', tktid) 
    rows = cursor.fetchall() 
    for row in rows: 
        emails += row[0] and self.get_email_addresses(row[0]) or [] 

has been replaced with (starting at line 310 in Notify.py)

    cursor.execute("SELECT DISTINCT author,ticket FROM ticket_change " 
                   "WHERE ticket=%s", (tktid,)) 
    for author,ticket in cursor: 
        recipients.append(row[0]) 

In the last line, row[0] should be replaced with author.

Attachments

Ticket_2408.patch (484 bytes) - added by dbrocher@… 6 years ago.
This patch fixes the problem in the trunk at the current revision 2569

Download all attachments as: .zip

Change History

Changed 6 years ago by dbrocher@…

This patch fixes the problem in the trunk at the current revision 2569

comment:1 Changed 6 years ago by anonymous

  • Owner changed from jonas to anonymous

comment:2 Changed 6 years ago by anonymous

  • Owner changed from anonymous to dbrocher@…

comment:3 Changed 6 years ago by anonymous

  • Owner changed from dbrocher@… to jonas

comment:4 Changed 6 years ago by dbrocher@…

  • Milestone set to 0.9.3

I think this should be fixed in the next milestone. Thanks.

comment:5 Changed 6 years ago by eblot

  • Owner changed from jonas to eblot
  • Status changed from new to assigned

Already fixed in the notification sandbox [2519].
I think (hope) this will effectively be commited to the trunk for 0.9.3

comment:6 Changed 6 years ago by anonymous

  • Milestone changed from 0.9.3 to 0.9.4

comment:7 Changed 6 years ago by eblot

  • Resolution set to fixed
  • Status changed from assigned to closed

Should be fixed in [2799] for 0.10
Should be fixed in [2823] for 0.9

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from eblot. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.