Email notification to reporters is broken

[dbrocher@…]

Setting always_notify_reporter = true is meant to send notification emails for ticket changes to the original author of the ticket and also every author of a ticket change. The latter doesn't work in version 0.9. The bug has been introduced in changeset [1343], where the following code starting at line 294 in Notify.py

    cursor.execute('SELECT DISTINCT author,ticket FROM ticket_change ' 
                   ' WHERE ticket=%s', tktid) 
    rows = cursor.fetchall() 
    for row in rows: 
        emails += row[0] and self.get_email_addresses(row[0]) or [] 

has been replaced with (starting at line 310 in Notify.py)

    cursor.execute("SELECT DISTINCT author,ticket FROM ticket_change " 
                   "WHERE ticket=%s", (tktid,)) 
    for author,ticket in cursor: 
        recipients.append(row[0]) 

In the last line, row[0] should be replaced with author.

[dbrocher@…]

This patch fixes the problem in the trunk at the current revision 2569

[dbrocher@…]

I think this should be fixed in the next milestone. Thanks.

[eblot]

Already fixed in the notification sandbox [2519]. I think (hope) this will effectively be commited to the trunk for 0.9.3

[eblot]

Should be fixed in [2799] for 0.10
Should be fixed in [2823] for 0.9