Ticket #2036 (new defect)
Opened 6 years ago
Last modified 12 months ago
Inconsistent sub-menu on Browse Source comparing with View Tickets
| Reported by: | pkou at ua.fm | Owned by: | cboos |
|---|---|---|---|
| Priority: | normal | Milestone: | next-major-0.1X |
| Component: | report system | Version: | 0.9b1 |
| Severity: | minor | Keywords: | query |
| Cc: | |||
| Release Notes: | |||
| API Changes: | |||
Description
Menu View Tickets contains two sub-items:
- Available Reports
- Custom Query
An item are not clickable when active.
In opposite, Browse Source contains one sub-item that changes its value depending on the active selection:
- Revision Log
- View Latest Revision
This needs to be unified in either way.
Attachments
Change History
comment:1 Changed 6 years ago by cboos
comment:2 Changed 6 years ago by Manuzhai
I think it's good to show the inactive link. That way, links are always in the same place, allowing for effective muscle memory clicking.
comment:3 Changed 6 years ago by cmlenz
- Milestone changed from 0.9 to 1.0
I agree with Manuzhai that showing the inactive link is good. It indicates where you currently are, as opposed to showing only where you can go.
The navigation links in the browser are not exactly the same story, however. View Latest Revision would need to be renamed, at least, because it would not make sense to show that label as inactive link when looking at an older revision.
Anyway, this can wait until after 0.9 IMO.
(And also IMO, the whole subnavigation story needs to be completely redesigned... it's a mess).
comment:4 Changed 22 months ago by cboos
- Milestone changed from 1.0 to unscheduled
Milestone 1.0 deleted
comment:5 Changed 17 months ago by cboos
- Component changed from general to report system
- Keywords query added
- Milestone changed from triaging to 0.13
- Owner changed from jonas to cboos
- Priority changed from low to normal
With the changes in attachment:custom-query-link.patch:ticket:9604, the "inactive" link is no longer inactive, but goes back to a "new" default custom query (kind of "Reset").
comment:6 Changed 17 months ago by cboos
Which leaves us with not showing the Available Reports contextual link as inactive when viewing the list of Available Reports. I'll fix that if nobody objects.
comment:7 Changed 12 months ago by cboos
- Milestone changed from 0.13 to next-major-0.1X



If this needs unification, I would propose to modify the View Tickets
to match Browse Source: only active links should be shown.
In the View Tickets, there's no point to show the inactive link,
as this is redundant with the page title.
See also TracProject/UiGuidelines.