#9989 closed enhancement (fixed)
Threaded comments for ticket change history
| Reported by: | cboos | Owned by: | cboos |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.0 |
| Component: | ticket system | Version: | 0.13dev |
| Severity: | normal | Keywords: | comment |
| Cc: | |||
| Release Notes: |
Ticket comments can now be displayed threaded (requires javascript) |
||
| API Changes: | |||
Description
I was sure there was already a ticket for that… apparently not.
Anyway, the idea is not new. For tickets with a long and complicated history, a simple linear view of the change history can be difficult to follow. We have the follow-up/in reply to links, but that doesn't give an immediate visual representation of the structure, one has to click and follow the links.
Fortunately that "follow-up" information is all we need to re-organize the comments in a tree, using Javascript. The proposed UI for that is a "Threaded Comments" checkbox next to the Change History section.
When activated, changes are displayed like this:
Attachments (2)
Change History (6)
Changed 2 years ago by cboos
comment:1 Changed 2 years ago by cboos
- Resolution set to fixed
- Status changed from new to closed
comment:2 follow-up: ↓ 3 Changed 2 years ago by cboos
- Resolution fixed deleted
- Status changed from closed to reopened
- Type changed from defect to enhancement
Already noticed a few glitches:
- the "inreply.png" arrow is also added to li.entry elements of embedded patches; apparently the CSS rule ul.children > li matches also for li entries not immediate children of ul.children, which I didn't expect from my limited understanding of CSS
- the left border could be improved (e.g. 1px solid #eee)
- the indent of the <li> elements could be a bit narrower ⇒ not found how to do it yet
As a side note:
Also, I've got trouble testing this at all in IE9, as an exception was thrown earlier from resizer.js:
var grip = $('<div class="trac-grip"/>').mousedown(beginDrag)[0];
(Object doesn't support this property or method thrown later in clone() in jquery.js - maybe a problem due to the recent switch to jQuery 1.5?). Hm. Actually there are lots of other problems with IE9. Strange, I didn't notice this when testing 1.5rc1. Right, this is http://bugs.jquery.com/ticket/8052.
comment:3 in reply to: ↑ 2 Changed 2 years ago by cboos
- Resolution set to fixed
- Status changed from reopened to closed
… a few glitches:
All of these should be addressed in the follow-up changeset r10516.
comment:4 Changed 17 months ago by Alex Willmer <al.willmer@…>
- Release Notes modified (diff)



![illustrates [attachment:threaded-comments-r10450.patch] illustrates [attachment:threaded-comments-r10450.patch]](/raw-attachment/ticket/9989/Threaded%20Comments.png)
illustrates threaded-comments-r10450.patch