resync single revision doesn't resync the node_change table

[barry@…]

repository resync repo revision doesn't do anything with the node_change table. This results in an incomplete resync. The only code I see that will resync the node_change table is a full repo resync. Is this by design or a bug? How does one completely resync a single svn revision?

[Christian Boos]

That's by design, we only reset the metadata of the revision.

repository sync <repos> [rev]

    Resume synchronization of repositories

    It works like `resync`, except that it doesn't clear the already
    synchronized changesets, so it's a better way to resume an interrupted
    `resync`.

    See `resync` help for detailed usage.

(as you can see, the inline doc is incomplete…)

This was implemented in order to support the post-revprop hook in Subversion (#6016).

The only reason I could see to resync completely a single svn change would be in case the actual file changes changed… did they implement svnadmin backout? ;-)

[barry@…]

See #9979 for the reason to resync a single svn change.

[Christian Boos]

Kept open for improving the trac-admin docs.

The idea would be to keep resync rev as it is (only about metadata), and have support sync rev for forcing the sync to start at rev instead of the youngest (use #9979 for that).

[Christian Boos]

Follow-up to cboos:

That's by design, we only reset the metadata of the revision.

repository sync <repos> [rev]

   Resume synchronization of repositories

   Similar to `resync`, but doesn't clear the already synchronized changesets.
   Useful for resuming an interrupted `resync`.

   To synchronize all repositories, specify "*" as the repository.

(as you can see, the inline doc is incomplete…)

We should actually make it clearer that it's the same as resync, something like:

repository sync <repos> [rev]

   Resume synchronization of repositories

   It works like `resync`, except that it doesn't clear the already 
   synchronized changesets, so it's a better way to resume an interrupted
   `resync`.

   See `resync` help for detailed usage.

[Remy Blank]

Change committed in [10850].