Allow rulers of diverse thickness, from 1 to 7 px, à la MoinMoin

[Juanma Barranquero]

On the same vein that #988, another ​MoinMoin-inspired patch for added WikiFormatting: allow rulers of diverse thickness , from 1 to 7px. (I'm not suggesting TracWiki should adopt every single wiki-formatting rule out there, but these two are simple to use and simple to implement; a bit more flexibility in tables would be nice, too ;)

htdocs/css/trac.css

@@ -17 +17 @@
 h3 { font-size: 14px; margin: 1.5em 0 .5em }
-hr { border: none;  border-top: 1px solid #ccb; margin: 2em 0 }
 address { font-style: normal }
@@ -21 +20 @@
 
+hr { border: none;  border-top: 1px solid #ccb; margin: 2em 0 }
+hr.hr1 { border-top: 1px solid #ccb }
+hr.hr2 { border-top: 2px solid #ccb }
+hr.hr3 { border-top: 3px solid #ccb }
+hr.hr4 { border-top: 4px solid #ccb }
+hr.hr5 { border-top: 5px solid #ccb }
+hr.hr6 { border-top: 6px solid #ccb }
+hr.hr7 { border-top: 7px solid #ccb }
+
 .underline { text-decoration: underline }

trac/WikiFormatter.py

@@ -556 +556 @@
                 self.close_table()
-                self.out.write('<hr />' + os.linesep)
+                self.out.write('<hr class="hr%s"/>' % min(7, len(line) - 3) + os.linesep)
                 continue

trac/tests/wiki-tests.txt

@@ -190 +190 @@
 </p>
+==============================
+-
+--
+---
+----
+-----
+------
+-------
+--------
+---------
+----------
+-----------
+------------------------------
+<p>
+-
+--
+---
+</p>
+<hr class="hr1"/>
+<hr class="hr2"/>
+<hr class="hr3"/>
+<hr class="hr4"/>
+<hr class="hr5"/>
+<hr class="hr6"/>
+<hr class="hr7"/>
+<hr class="hr7"/>

[Christopher Lenz]

I personally don't see the value in this. Thick <hr>s are ugly, and the thickness isn't backed by a semantic differentiation in the markup, i.e. the effect is purely presentational. HTML doesn't have any provision for <hr>s of different "importance". Compare this to different heading levels, where the difference is backed by the document structure.

This change would also effect existing wiki text where the number of dashes did not make a difference, and now suddenly would. Fewer than four dashes are currently not rendered as <hr> at all, with this change they suddenly would be.

[Juanma Barranquero]

I personally don't see the value in this.

Fair enough.

Fewer than four dashes are currently not rendered as <hr> at all, with this change they suddenly would be.

Only if I made an error…

[Christopher Lenz]

Only if I made an error...

You're right, I misread the patch. Sorry.