Edgewall Software
Modify

Opened 4 years ago

Last modified 4 weeks ago

#9807 new enhancement

Wrong sections are collapsed by default!

Reported by: morgand Owned by:
Priority: normal Milestone: next-major-releases
Component: ticket system Version:
Severity: normal Keywords: preferences
Cc: andrew.c.martin@…, oleg@…, trachacks@…, osimons, rjollos
Release Notes:
API Changes:

Description

Collapsing the sections in a ticke is great - the trouble is that the section that is used 99% of the time is the "modify" section which is pre-collapsed.

An ideal solution would be to make this system configurable (or even user configurable).

It is going to pee-off my users to now have to press that extra button… petty I know…. but its the truth.

Attachments (0)

Change History (35)

comment:1 Changed 4 years ago by anonymous

I think it would be a great idea.

comment:2 Changed 4 years ago by Andrew C Martin <andrew.c.martin@…>

  • Cc andrew.c.martin@… added

I concur. One of the first things I'm going to do when I upgrade my trac installation is modify the ticket.html template to open up the "Modify Ticket" frame by default.

comment:3 Changed 4 years ago by rblank

It probably depends what you do most often, read tickets and add comments or modify tickets. I would venture that the former is far more frequent for most users.

One thing we could do, though, is expand the "Modify ticket" section when previewing a ticket change, as one is likely to make more changes in that case.

comment:4 Changed 4 years ago by rblank

  • Milestone set to next-major-0.1X
  • Owner set to rblank

comment:5 Changed 4 years ago by morgand@…

rblank - I dont agree that the "read" is the most common action.

In a worklowed environment any activity on a ticket is recorded hence there is rarely any instance when a ticket is read without some action being performed - hence the default need for the "modify".

If tickets were not workflowed - and you had a "pick-and-mix" approach I would agree that tickets would be read (and left for someone else)…

comment:6 Changed 4 years ago by rblank

It certainly is for me and for the users of my systems. So I guess it depends on your audience.

comment:7 Changed 4 years ago by mrelbe

User configurable: +1

comment:8 Changed 4 years ago by cboos

  • Keywords userpreferences added

comment:10 Changed 3 years ago by anonymous

I am getting carpal tunnel from clicking that "Expand" triangle, after only a day of using 0.12. Can somebody explain for noobs how to do the workaround in the stackoverflow post above?? I have no idea where to make this change.

comment:11 follow-up: Changed 3 years ago by gt4329b

Add me to the list of votes for "User configurable" …but configurable for all sections: "Attachment", "Change History", and "Modify Ticket" should all have user prefs for "On page load:" show <section> as "Server default", "Expanded", "Collapsed"

comment:12 Changed 3 years ago by Oleg Pudeyev <oleg@…>

Please make the collapsing of 'modify ticket' configurable. I understand the confusion between the two text boxes but having to constantly expand the form is worse than having to pay attention which text box to enter comments into.

comment:13 Changed 3 years ago by Oleg Pudeyev <oleg@…>

  • Cc oleg@… added

comment:14 Changed 3 years ago by Oleg Pudeyev <oleg@…>

It looks like #8295 is responsible for the current behavior.

comment:15 Changed 3 years ago by didley@…

Is it possible to add an extra line in site.htm to decide collapse or un-collapse of ticket modify per project?

comment:16 in reply to: ↑ 11 ; follow-up: Changed 3 years ago by trachacks@…

  • Cc trachacks@… added

Replying to gt4329b:

Add me to the list of votes for "User configurable" …but configurable for all sections: "Attachment", "Change History", and "Modify Ticket" should all have user prefs for "On page load:" show <section> as "Server default", "Expanded", "Collapsed"

I strongly second this motion. trac.ini server defaults at least, but user configurable overrides would be great. Complicating the matter a bit, is the fact that several plugins add their own collapsible sections. There is th:TracTicketChangelogPlugin and th:ChildTicketsPlugin, and maybe more.

This issue keeps me from switching from 0.11.7 to 0.12.2 right away.

comment:17 in reply to: ↑ 16 ; follow-up: Changed 3 years ago by rblank

Replying to trachacks@…:

I strongly second this motion. trac.ini server defaults at least, but user configurable overrides would be great. Complicating the matter a bit, is the fact that several plugins add their own collapsible sections. There is th:TracTicketChangelogPlugin and th:ChildTicketsPlugin, and maybe more.

If one additional click is already too much, then you guys aren't going to like 0.13, where editing the ticket comment collapses the "Modify Ticket" section. And before you ask: yes, there are very good reasons for that (see #7145).

This issue keeps me from switching from 0.11.7 to 0.12.2 right away.

Oh, come on. You can't be serious there.

For those who are so paralyzed by this feature that it prevents them from using Trac, set your site.html to the following (or add the relevant snippet to your existing site.html):

<html xmlns="http://www.w3.org/1999/xhtml"
      xmlns:py="http://genshi.edgewall.org/"
      py:strip="">
  <head py:match="head" py:attrs="select('@*')">
    ${select('*|comment()|text()')}
    <script type="text/javascript">
      jQuery(document).ready(function($) {
        $("#modify").parent().removeClass("collapsed");
      });
    </script>
  </head>
</html>

See? It wasn't that difficult, was it?

comment:18 Changed 3 years ago by rblank

Or if you want the JavaScript snippet only on the ticket page:

<html xmlns="http://www.w3.org/1999/xhtml"
      xmlns:py="http://genshi.edgewall.org/"
      py:strip="">
  <div py:match="div[@id='content' and @class='ticket']//div[@id='modify']" py:attrs="select('@*')">
    ${select('*|comment()|text()')}
    <script type="text/javascript">
      jQuery(document).ready(function($) {
        $("#modify").parent().removeClass("collapsed");
      });
    </script>
  </div>
</html>

comment:19 follow-up: Changed 3 years ago by cboos

Sure, this can be changed locally by Trac admins, but I think the point people try to make here is that in the end this is an user preference. A Trac user can't generally influence what's in the site.html of the various Tracs they use over the web ;-)

So maybe we could have an "User Interface" tab in the "Preferences", with a "Ticket" fieldset and an entry "[ ] Auto-collapse forms"?

comment:20 in reply to: ↑ 19 Changed 3 years ago by rblank

  • Owner rblank deleted

Replying to cboos:

So maybe we could have an "User Interface" tab in the "Preferences", with a "Ticket" fieldset and an entry "[ ] Auto-collapse forms"?

Sure, that's why I didn't close this ticket. I was replying to the comment "This issue keeps me from switching from 0.11.7 to 0.12.2 right away".

(Why did I assign this to me?)

comment:21 in reply to: ↑ 17 Changed 3 years ago by oleg

Replying to rblank:

If one additional click is already too much, then you guys aren't going to like 0.13, where editing the ticket comment collapses the "Modify Ticket" section. And before you ask: yes, there are very good reasons for that (see #7145).

There are good reasons for *some people* and for other people these are rather annoying and bad reasons. Perhaps the reason why more people have not complained is that this "feature" does not make trac unusable, so it is more of an annoyance than a showstopper. Or maybe it's because plenty of installations are still at 0.11 (usually due to plugin or local patch incompatibility with 0.12 - which is why patching locally is not a great idea). However given the amount of support already present in this ticket there clearly is a substantial number of people who don't want the fields they use all the time be collapsed on them.

As far as #7145 goes, on my screen the form occupies about ½ of screen height and you're right, I don't want my trac experience be made miserable by people on 640x480 resolutions that seem to be all the rage these days.

If I want to see the entire preview, I am happy to scroll to it.

Again, I support hiding things for those who want them hidden, but not at the expense of also hiding them for those who don't want them hidden.

Sure, this can be changed locally by Trac admins, but I think the point people try to make here is that in the end this is an user preference.

Even if this currently is an easy change to make, future revisions may make it a difficult change to make, as #7145 demonstrates. Thus having official support for choosing the behavior for the entire trac install is still better than having to patch the code.

comment:22 Changed 3 years ago by Ryan J Ollos <ryano@…>

  • Cc ryano@… added

comment:23 Changed 3 years ago by jbell@…

Why not just remember which fields were collapsed?

comment:24 Changed 3 years ago by paulcarlisle@…

My two cents: me - and all of my developers - want that field expanded by default. Ideally, as others have noted, it should be configurable. I don't really care if I can configure it via the web interface or simply through the INI file, but it's something I ought to be able to set for myself. Same with all the other foldable fields, for that matter.

Thanks for the site.html workaround. As our number of projects grows, though, copying this into several different directories grows cumbersome.

comment:25 Changed 3 years ago by osimons

It certainly is a preference thing at some level. My users want it expanded too. With mostly corporate users, almost all edits also involve some type of field change - they rarely spend time on tickets just to offer their opinions, they edit tickets because something needs to be updated.

Thanks for the site.html snippet, that came in handy. I've made a minor modification to not expand for 'Preview' mode. For preview it still makes sense to collapse all other sections to focus on the updated information.

<!--! Expand "Modify Ticket" by default -->
<div py:match="div[@id='content' and @class='ticket']//div[@id='modify']"
     py:attrs="select('@*')">
  ${select('*|comment()|text()')}
  <script type="text/javascript"
          py:if="not 'preview' in req.args">
    jQuery(document).ready(function($) {
      $("#modify").parent().removeClass("collapsed");
    });
  </script>
</div>

comment:26 Changed 3 years ago by osimons

  • Cc osimons added

comment:27 follow-ups: Changed 3 years ago by anonymous

Please let me express my own humble opinion:

Generally I like very much the TRAC 0.12 feature of foldable (aka. expandable or collapse-able) sections in the ticket view. But like other I am not 100% happy with the default expansion status in Trach 0.12.2: Per default "Modify Ticket" is collapsed and "Change History" is expanded. However, in our work flow we never use ticket comments. If we want to add something to a ticket, then we simply modify the description. Now you can understand why the "Change History" with the comments is not much interesting for us, instead the "Modify Ticket" section is much more important for us. Instead I would rather like the "Ticket history", and "Attachment" to be closed by default while the "Change Ticket" section shall be opened.

In my opinion a central configuration (by administrator via config file?) would be OK.

But I am willing to accept any solution. I tried to modify the code snipped for site.html in comment:25, but could not reach a solution. Does anybody know how to change the snipped to reach my goal?

comment:28 in reply to: ↑ 27 ; follow-up: Changed 3 years ago by c.feige@…

Replying to anonymous:

I tried to modify the code snipped for site.html in comment:25, but could not reach a solution. Does anybody know how to change the snipped to reach my goal?

Please do not misunderstand. The snipped for in site.html in comment:25 does exactly what it promises: Expanding "Modify Ticket" by default. But how can I additionally also collapse the "Change History"?

comment:29 in reply to: ↑ 27 Changed 3 years ago by c.feige@…

Replying to anonymous:

… I would rather like the "Ticket history", and "Attachment" to be closed by default while the "Change Ticket" section shall be opened. …

I was able to solve my above issue. Here is what you need to put into the site.html template:

 <!-- Expand "Modify Ticket" by default.
      inspired by http://trac.edgewall.org/ticket/9807#comment:18 -->
 <div py:match="div[@id='content' and @class='ticket']//div[@id='modify']" py:attrs="select('@*')">
      ${select('*|comment()|text()')}
      <script type="text/javascript">
        jQuery(document).ready(function($) {
        $("#modify").parent().removeClass("collapsed");
        });
      </script>
 </div>

 <!-- Collapse "Ticket History" by default
      inspired by http://trac.edgewall.org/ticket/9807#comment:18 -->
 <div py:match="div[@id='content' and @class='ticket']//div[@id='changelog']" py:attrs="select('@*')">
      ${select('*|comment()|text()')}
      <script type="text/javascript">
        jQuery(document).ready(function($) {
        $("#changelog").parent().toggleClass("collapsed");
        });
      </script>
 </div> 

comment:31 in reply to: ↑ 28 Changed 2 years ago by anonymous

Replying to c.feige@…:

Replying to anonymous:

I tried to modify the code snipped for site.html in comment:25, but could not reach a solution. Does anybody know how to change the snipped to reach my goal?

Please do not misunderstand. The snipped for in site.html in comment:25 does exactly what it promises: Expanding "Modify Ticket" by default. But how can I additionally also collapse the "Change History"?

I decided I just wanted to get the change history collapsed, this is what my site.html looks like:

<html xmlns="http://www.w3.org/1999/xhtml" xmlns:py="http://genshi.edgewall.org/" py:strip="">
 
  <head py:match="head" py:attrs="select('@*')">
    ${select('*|comment()|text()')}
    <script type="text/javascript">
      jQuery(document).ready(function($) {
        //$("#modify").parent().removeClass("collapsed");
        $("#changelog").parent().addClass("collapsed");
      });
    </script>
  </head>

</html>

Note that I left in the line that can be used to expand the modify section by default, but I commented it out so it's non-functional, but I can re-enable it on a whim.

comment:32 Changed 2 years ago by commercial@…

Here's another strong vote for auto-expanding the Modify section. My company considers this unusable without a hack (that we've made for both 0.11 and 0.12) to comment out the toggleClass("collapsed") command in the Ticket.html template.

At the very least, this should be configurable.

comment:33 Changed 2 years ago by cboos

Yet another user preference candidate…

comment:34 Changed 14 months ago by szybalski@…

Hello, Configurable would be great, with a default installation to be expended.

We have 815,000 tickets in trac right now. 3 years running. ~65 people using it. They all expressing that making them click another button is yet another delay. "What used to take them 20min in 0.11. takes them 30min in 0.12".

I did install the comment #18. I just wanted to throw in our numbers and say less clicks is always better. "Emphasize the content people need". In our case we need this section expended by defaul 815K times vote.

comment:36 Changed 5 weeks ago by rjollos

  • Cc rjollos added; ryano@… removed

comment:37 Changed 4 weeks ago by rjollos

  • Keywords preferences added; userpreferences removed

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as new The ticket will remain with no owner.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.