CommitTicketUpdater should have an option to specify action

[Marcus Lindblom <macke@…>]

We don't close tickets with commits, we mark them as fixed so they can be tested.

It's a simple replacement of the action/state on ​line 249 that could be fetched from the TracIni config.

[Remy Blank]

We can't possibly handle all possible situations in that component, as there are just too many possibilities. That's why we made the CommitTicketUpdater component so that it can easily be subclassed to provide your own implementation of actions (in this case, override cmd_close()).

This can be done in a single-file plugin placed in the plugins folder of the environment. Something like (untested):

from tracopt.ticket.commit_updater import CommitTicketUpdater

class CommitUpdater(CommitTicketUpdater):
    def cmd_close(self, ticket, changeset, perm):
        if not self.check_perms or 'TICKET_MODIFY' in perm:
            ticket['status'] = 'fixed'

The single-file plugin will be activated automatically, and you should make sure to disable the original CommitTicketUpdater.

[Marcus Lindblom <macke@…>]

Ok. Fully understandable! :)

I think can code something like that, and see if it can go on trac-hacks.org eventually.

Thanks for pointing me in the right direction!

[plittle@…]

Just commenting that this is a really nice way to make the builtin stuff extensible. Bookmarking for reference.