Opened 3 years ago
Closed 3 months ago
#9590 closed defect (worksforme)
Display of Patch/Diff file broken
| Reported by: | hakre | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | rendering | Version: | 0.11.7 |
| Severity: | major | Keywords: | diff verify |
| Cc: | |||
| Release Notes: | |||
| API Changes: | |||
Description
When looking into an attachment that is a patch file that contains changes to PHP code that is related to Diff, it looks like trac has problems to properly display that patchfile. It just stops somewhere in between.
Example: http://core.trac.wordpress.org/attachment/ticket/14726/14726.2.patch
Attachments (2)
Change History (7)
Changed 3 years ago by hakre
comment:1 Changed 3 years ago by hakre
I needed to replace the original patch file of the example so making the example link not work any longer. To check, I've attached that original patch file here. I needed to put it in a zip otherwise it was reported as spam.
comment:2 Changed 3 years ago by rblank
Strangely, the patch from the .zip seems to be displayed correctly…
comment:3 Changed 3 years ago by cboos
- Component changed from general to rendering
- Keywords verify added
IIUC, the problem is with wp-includes/class-snoopy.php, which displays fine here, but not on core.trac.wordpress.org.
Maybe due to the default_encoding setting?
comment:4 Changed 3 years ago by cboos
- Keywords diff added
- Milestone set to next-minor-0.12.x
- Severity changed from normal to major
comment:5 Changed 3 months ago by cboos
- Milestone next-minor-0.12.x deleted
- Resolution set to worksforme
- Status changed from new to closed
Looks like the reported problematic link look fine now. They're now running 0.12.4, so I assume this must have been fixed along the way.
example file that originally broke - patch on example page has been replaced