wiki-toc float value should be RTL-aware

[Itamar Oren]

The TracGuide and TocMacro use the wiki-toc class for floating div.

When a page is right-to-left, the floating div should be floating left.

Assuming right-to-left pages are created using some top-level container of the form:

{{{
#!div class=rtl
...
}}}

The direction-aware float may be achieved with the attached rtl-css.patch​ patch.

[Itamar Oren]

Patch that introduces some RTL support to CSS

[Christian Boos]

Thanks for the patch!

[Itamar Oren]

See also the ​DirClassMacro I published on t-h.org.

It adds the CSS suggested in this patch, and also introduces [[RTL]] and [[LTR]] macros that emit right-aligned div tags and closing tags, respectively.

This even interacts correctly with ​TracWysiwygPlugin, which had a problem with aligned-div-tags as suggested in the ticket description.

A possible issue I've noticed is that if I use [[RTL]] with no matching [[LTR]], and I edit in side-by-side mode, then just after clicking Show Preview the editing area and action buttons either disappear completely or appear below the preview instead of to the side.

Anyway, I suggest to integrate the macro in core, as another step toward RTL-support.

[Christian Boos]

Replying to itamaro:

Anyway, I suggest to integrate the macro in core, as another step toward RTL-support.

No, we don't want to support any macro that introduces non well-formed XHTML, i.e. begin a div in one macro, close it in another. The proper way to do this would be a #!rtl processor, but then I wonder if it adds more than a #!div class=rtl? It's still a bit more convenient to write, so we could support it anyway.

[Remy Blank]

I have applied rtl-css.patch​ in [10547]. I'll also quicly implement a #!rtl processor for convenience.

[Remy Blank]

[10548] adds the #!rtl wiki processor.

[Itamar Oren]

RTL subtlety regarding indentation of wiki-toc floats

[Itamar Oren]

Reopening the ticket in order to submit an additional patch that enhances the previous one, as far as the indentation of RTL-wiki-toc floats is concerned (see rtl-css-indent.patch​)

[Remy Blank]

Applied in [10736].